Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prior args for MAP cost function #360

Closed
BradyPlanden opened this issue Jun 13, 2024 · 0 comments · Fixed by #483
Closed

Add prior args for MAP cost function #360

BradyPlanden opened this issue Jun 13, 2024 · 0 comments · Fixed by #483
Labels
enhancement New feature or request

Comments

@BradyPlanden
Copy link
Member

Feature description

Update the MAP cost function to allow for prior to be passed on construction. Keep the current functionality that defines these from the Parameters class, but only if the default priors arg is passed.

Motivation

No response

Possible implementation

Functionality should look like this:

prior1 = pybop.Gaussian(0.1, 0.01)
prior2 = pybop.Uniform(0.5, 0.6)
cost = pybop.MAP(problem, prior=[prior1, prior2])

Additional context

No response

@BradyPlanden BradyPlanden added the enhancement New feature or request label Jun 13, 2024
@BradyPlanden BradyPlanden moved this to Todo in v24.9 Jul 18, 2024
@BradyPlanden BradyPlanden linked a pull request Sep 6, 2024 that will close this issue
15 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in v24.9 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant