Adding tests to exercise corner cases involving disowning. #2912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most interesting corner case is in test_class_sh_disowning.py
test_mixed
. See comments there. A "maybe later" idea:ValueError
"disowned" for one or more arguments. If this is true for the winning overload, raise a special exception before actually converting any arguments, to make the behavior predictable/portable (no arguments will be disowned).This PR also fixing minor namespace naming inconsistencies across test_class_sh_*.cpp files.