-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
define PYBIND11_USE_SMART_HOLDER_AS_DEFAULT #2879
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6400097
to
014a598
Compare
a1bed77
to
5fa65f5
Compare
This was referenced Mar 16, 2021
8b953d6
to
5b429f3
Compare
12981e9
to
4a00234
Compare
173c0ed
to
6111f94
Compare
3f2fcc9
to
8699092
Compare
6dba6e0
to
4136b47
Compare
…1_SH_DEF to test_factory_constructors.py to complete test coverage.
…mplete test coverage.
…lete test coverage.
This PR was made obsolete by #2963. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
smart holder
See: https://github.com/pybind/pybind11/blob/smart_holder/README_smart_holder.rst
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IGNORE this PR please.
This is purely for running the CI against branch
smart_holder
(or other branches based on branch `smart_holder), with the only difference that PYBIND11_USE_SMART_HOLDER_AS_DEFAULT is defined.