Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy to less than 2.0.0 #4186

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Jun 17, 2024

Description

Temporary pin for the numpy version

Related #4183

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman kratman changed the title Pin numpy for now Pin numpy to less than 2.0.0 Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (20046d4) to head (8828a1e).
Report is 208 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4186   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          288      288           
  Lines        21797    21797           
========================================
  Hits         21706    21706           
  Misses          91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kratman kratman merged commit 853417c into pybamm-team:develop Jun 17, 2024
25 of 26 checks passed
@agriyakhetarpal agriyakhetarpal deleted the fix/pinNumpy branch June 17, 2024 13:30
@agriyakhetarpal agriyakhetarpal mentioned this pull request Jun 18, 2024
8 tasks
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants