Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with NumPy v2 #4183

Open
agriyakhetarpal opened this issue Jun 16, 2024 · 6 comments · Fixed by #4196
Open

Compatibility with NumPy v2 #4183

agriyakhetarpal opened this issue Jun 16, 2024 · 6 comments · Fixed by #4196
Assignees
Labels
priority: high To be resolved as soon as possible

Comments

@agriyakhetarpal
Copy link
Member

NumPy version 2.0.0 has been released today – we'll need to fix the failing unit tests. The tests are coming from autograd and the authors mention that they don't intend to maintain the dependency anymore so we should aim to remove it altogether, either now or later

@agriyakhetarpal agriyakhetarpal added the priority: high To be resolved as soon as possible label Jun 16, 2024
@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Jun 16, 2024

As discussed, can be done after the release of v24.5rc0 with an upper pin on NumPy and that can be then removed after v24.5rc1 or with v24.9

@brosaplanella
Copy link
Member

@valentinsulzer shall we reopen this one?

@brosaplanella brosaplanella reopened this Jun 24, 2024
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@kratman kratman self-assigned this Nov 21, 2024
@kratman
Copy link
Contributor

kratman commented Nov 21, 2024

I have PyBaMM compatible with numpy <=2.0.2, but compatibility with 2.1.0 is still in progress. This is likely needed for upgrading to python 3.13

@doelgonzo
Copy link

Any update on this? I am working within JupyterLite which ships with numpy==2.0.2, and of course this is failing to install PyBaMM

@kratman
Copy link
Contributor

kratman commented Feb 6, 2025

@doelgonzo I actually have a branch working for numpy==2.0.2, but it requires a lot of changes to go much above that. We will likely have to deprecate python 3.9, update Jax, and do a few other changes to get it working. I expect that to be sorted out in a couple months

@agriyakhetarpal
Copy link
Member Author

Any update on this? I am working within JupyterLite which ships with numpy==2.0.2, and of course this is failing to install PyBaMM

In the meantime, you could use jupyterlite-pyodide-kernel==0.4.6, as we shipped Pyodide 0.26.x with that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high To be resolved as soon as possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants