-
-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bcs for the particle models #1421
Fixed bcs for the particle models #1421
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1421 +/- ##
========================================
Coverage 98.27% 98.27%
========================================
Files 278 279 +1
Lines 16109 16131 +22
========================================
+ Hits 15831 15853 +22
Misses 278 278
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @brosaplanella !
Description
Changed how
D
is evaluated at the boundary condition to ensure that mass is conserved. I also changed some of thestandard_output_tests
to catch when mass is not conserved (before it didn't) and fixed some others.Fixes #1420
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: