Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definition of bcs in particle models #1420

Closed
brosaplanella opened this issue Mar 6, 2021 · 0 comments · Fixed by #1421
Closed

Fix definition of bcs in particle models #1420

brosaplanella opened this issue Mar 6, 2021 · 0 comments · Fixed by #1421
Assignees

Comments

@brosaplanella
Copy link
Member

Describe the bug
With the current implementation the particle model doesn't conserve mass when the diffusion coefficient is not constant. This is because the diffusivity at the boundary is evaluated as D(pybamm.surf(c)) which is inconsistent with the definition in the divergence pybamm.surf(D(c)).

We basically need to change D(pybamm.surf(c)) into pybamm.surf(D(c)).

@brosaplanella brosaplanella self-assigned this Mar 6, 2021
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Mar 7, 2021
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Mar 7, 2021
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Mar 7, 2021
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Mar 7, 2021
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Mar 10, 2021
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Mar 10, 2021
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Mar 10, 2021
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant