Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label and select differ depending on markup #265

Closed
brianjmiller opened this issue Dec 20, 2013 · 3 comments
Closed

label and select differ depending on markup #265

brianjmiller opened this issue Dec 20, 2013 · 3 comments
Labels

Comments

@brianjmiller
Copy link

The two versions:

<label for="some-id">Some ID:</label>
<select id="some-id">.....</select>

And...

<label>
    Some ID
    <select>....</select>
</label>

Semantically should mean the same thing but appear to be styled differently because of how they inherit from their parents, particularly as relates to font size and therefore height.

This could catch someone off guard who was using the two different formats. Close WONTFIX and it won't bother me as I'm unlikely to use labels with "for" since it requires an id, nor am I likely to mix markup in the same form. But I thought I'd point it out.

@troyswanson
Copy link

Certainly a good idea. I've never used that second format before, so thanks for showing it!

@ericf
Copy link
Collaborator

ericf commented Jan 8, 2014

@brianjmiller yeah, agreed. We should remove the font-size declaration from .pure-form label. /cc @tilomitra

tilomitra added a commit to tilomitra/pure that referenced this issue Feb 10, 2014
@tilomitra
Copy link
Contributor

Yeah I agree. I sent a pull request that should fix this.

ericf added a commit that referenced this issue Feb 11, 2014
[Fix #265]: Remove `font-size` rules from .pure-form children
@ericf ericf mentioned this issue Feb 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants