-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
label and select differ depending on markup #265
Labels
Comments
Certainly a good idea. I've never used that second format before, so thanks for showing it! |
@brianjmiller yeah, agreed. We should remove the |
tilomitra
added a commit
to tilomitra/pure
that referenced
this issue
Feb 10, 2014
Yeah I agree. I sent a pull request that should fix this. |
ericf
added a commit
that referenced
this issue
Feb 11, 2014
[Fix #265]: Remove `font-size` rules from .pure-form children
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The two versions:
And...
Semantically should mean the same thing but appear to be styled differently because of how they inherit from their parents, particularly as relates to font size and therefore height.
This could catch someone off guard who was using the two different formats. Close WONTFIX and it won't bother me as I'm unlikely to use labels with "for" since it requires an id, nor am I likely to mix markup in the same form. But I thought I'd point it out.
The text was updated successfully, but these errors were encountered: