Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v 0.4.2 #297

Closed
ghost opened this issue Feb 14, 2014 · 5 comments
Closed

v 0.4.2 #297

ghost opened this issue Feb 14, 2014 · 5 comments

Comments

@ghost
Copy link

ghost commented Feb 14, 2014

this release a complete mess, has any one tested this release??

Legened, forms and buttons changed dramatically, fields now 2 times bigger, legend is showing normal text, why this happened?

@ericf
Copy link
Collaborator

ericf commented Feb 14, 2014

Yes this release was tested. We made a decisions based on the discussions in #265 to give an app's CSS more control over the font-size cascade. We simply removed some of these font-size declarations in favor of letting the defaults bubble up.

If you want your <legend>s to be larger and <input>s to be smaller, you can simply set their font-size. See the diff: v0.4.1...master#diff-6

@ericf ericf closed this as completed Feb 14, 2014
@ghost
Copy link
Author

ghost commented Feb 14, 2014

When you do such a change, huge installations using this library in prod are affected, this is not the way changes being taken on such high usage lib.

You can have these as options added not as the 'default' value to go and then you asking all these shops to go and do your 'proposal' to fix this issue!

@ericf
Copy link
Collaborator

ericf commented Feb 14, 2014

In order to us to keep making progress on Pure — a version 0 piece of software — we need to be able to make breaking changes. We have many major changes in the works which will change things dramatically.

Would it have helped if we called this recent version v0.5.0?

I will update the release notes to state that we removed font-size declarations from Forms. Sorry for the confusion.

@ghost
Copy link
Author

ghost commented Feb 15, 2014

I'm not professional on this topic, but at least there should be few releases (don't need to be minors) before depreciating a feature, in these releases you warning and depreciating BUT this is not the issue I think.

The issue that you have replaced nice features with somethings not being accepted at all as an upgrade (till now no one of our applications users found it nice to have this terrible looking forms, and we have a varieties of applications using pure).

I strongly advise you guys to revert back to the old one and have these 'extra big forms inputs' added as another option, legends are always considered as forms header group and need to be reflecting that.

There are things more important to be addressed such as responsive tables being ignored till this release.

The way Pure can expand is to keep its minimalist impact on any site, but here you enforce people either to accept these new bubbles or to rewrite pure, but majority of us don't even have single line modified, actually it's linked as cdn resource.

@ericf
Copy link
Collaborator

ericf commented Feb 15, 2014

The release specifically fixed issues to make Pure more minimalist and impact sites less by letting the default font sizes be applied.

Use the old version if you want, but we have plans to make big changes to the library and we're in no way done working on this project. If you don't want the things we change, use an older version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant