(GH-298) Fix tests for Facter 4.0.52 gem #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer use Travis or Appveyor. This commit updates the badge to the GitHub actions badge.
The facter 4.0.52 gem uses FFI to retrieve the legacy hostname fact. However as FFI wasn't available it was breaking the integration tests. This commit changes the expected fact name, from a legacy fact to a modern fact which should not ever be removed (facterversion).
|
|
jpogran
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #298
The facter 4.0.52 gem uses FFI to retrieve the legacy hostname fact. However as
FFI wasn't available it was breaking the integration tests. This commit changes
the expected fact name, from a legacy fact to a modern fact which should not
ever be removed (facterversion).