Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facter 4.0.52 is breaking the sidecar tests #298

Closed
glennsarti opened this issue Mar 31, 2021 · 0 comments · Fixed by #299
Closed

Facter 4.0.52 is breaking the sidecar tests #298

glennsarti opened this issue Mar 31, 2021 · 0 comments · Fixed by #299
Labels
bug Something isn't working
Milestone
1.2.0

Comments

@glennsarti
Copy link
Contributor

The integration tests for /spec/languageserver-sidecar/integration/puppet-languageserver-sidecar/facter_helper_spec.rb are failing on ubuntu.

This has only started happening with the Facter 4.0.52 release.
@glennsarti glennsarti added the bug Something isn't working label Mar 31, 2021
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Mar 31, 2021
@glennsarti
(puppetlabsGH-298) Fix tests for Facter 4.0.52 gem
7504f4f 
The facter 4.0.52 gem uses FFI to retrieve the legacy hostname fact. However as
FFI wasn't available it was breaking the integration tests. This commit changes
the expected fact name, from a legacy fact to a modern fact which should not
ever be removed (facterversion).
@glennsarti glennsarti mentioned this issue Mar 31, 2021
Merged
jpogran added a commit that referenced this issue Mar 31, 2021
@jpogran
Merge pull request #299 from glennsarti/fix-facter
926c2e0 
(GH-298) Fix tests for Facter 4.0.52 gem
@jpogran jpogran added this to the 1.2.0 milestone Mar 31, 2021
scoiatael pushed a commit to scoiatael/puppet-editor-services that referenced this issue Jan 14, 2022
@glennsarti
(puppetlabsGH-298) Fix tests for Facter 4.0.52 gem
222de4d 
The facter 4.0.52 gem uses FFI to retrieve the legacy hostname fact. However as
FFI wasn't available it was breaking the integration tests. This commit changes
the expected fact name, from a legacy fact to a modern fact which should not
ever be removed (facterversion).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

(GH-298) Fix tests for Facter 4.0.52 gem glennsarti/puppet-editor-services
2 participants
@jpogran @glennsarti