(GH-289) Make Format On Type file size configurable #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only files that were less than 4KB in size could use the format-on-type feature. This commit updates the Language Server to honor a new configuration setting puppet.editorService.formatOnType.maxFileSize which will determine the maximum file size. A size of 0 will disable the size check. The default is 4096 as per the previous behaviour. No specific tests have been added and has been manually tested.
glennsarti
force-pushed
the
gh289-format-file-size
branch
from
3e08c07 to
b8a3386
Compare
jpogran
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #289
Previously only files that were less than 4KB in size could use the
format-on-type feature. This commit updates the Language Server to honor a
new configuration setting puppet.editorService.formatOnType.maxFileSize which
will determine the maximum file size. A size of 0 will disable the size check.
The default is 4096 as per the previous behaviour.
No specific tests have been added and has been manually tested.