Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config setting for format on type file size limit #289

Closed
glennsarti opened this issue Jan 12, 2021 · 0 comments · Fixed by #290
Closed

Config setting for format on type file size limit #289

glennsarti opened this issue Jan 12, 2021 · 0 comments · Fixed by #290
Labels
enhancement New feature or request
Milestone
1.1.0

Comments

@glennsarti
Copy link
Contributor

From puppetlabs/puppet-vscode#695

Dynamically change file size limit
@glennsarti glennsarti added the enhancement New feature or request label Jan 12, 2021
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Jan 13, 2021
@glennsarti
(puppetlabsGH-289) Make Format On Type file size configurable
3e08c07 
Previously only files that were less than 4KB in size could use the
format-on-type feature. This commit updates the Language Server to honor a
new configuration setting puppet.editorService.formatOnType.maxFileSize which
will determine the maximum file size.  A size of 0 will disable the size check.
The default is 4096 as per the previous behaviour.

No specific tests have been added and has been manually tested.
@glennsarti glennsarti mentioned this issue Jan 13, 2021
Merged
@glennsarti glennsarti added this to the 1.1.0 milestone Jan 13, 2021
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Jan 13, 2021
@glennsarti
(puppetlabsGH-289) Make Format On Type file size configurable
b8a3386 
Previously only files that were less than 4KB in size could use the
format-on-type feature. This commit updates the Language Server to honor a
new configuration setting puppet.editorService.formatOnType.maxFileSize which
will determine the maximum file size.  A size of 0 will disable the size check.
The default is 4096 as per the previous behaviour.

No specific tests have been added and has been manually tested.
jpogran added a commit that referenced this issue Jan 13, 2021
@jpogran
Merge pull request #290 from glennsarti/gh289-format-file-size
f9b2fe2 
(GH-289) Make Format On Type file size configurable
scoiatael pushed a commit to scoiatael/puppet-editor-services that referenced this issue Jan 14, 2022
@glennsarti
(puppetlabsGH-289) Make Format On Type file size configurable
0f4a6be 
Previously only files that were less than 4KB in size could use the
format-on-type feature. This commit updates the Language Server to honor a
new configuration setting puppet.editorService.formatOnType.maxFileSize which
will determine the maximum file size.  A size of 0 will disable the size check.
The default is 4096 as per the previous behaviour.

No specific tests have been added and has been manually tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

(GH-289) Make Format On Type file size configurable glennsarti/puppet-editor-services
1 participant
@glennsarti