(GH-163) Use aggregate metadata actions for puppetstrings feature flag #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
force-pushed
the
add-aggregate-metadata
branch
from
34c01bf to
cb5cf1a
Compare
Previously the tests use private instance methods to verify the object, however the each_list method now does that. This commit changes the tests to use this method instead.
Previously the metadata aggregate action could only be used with the puppetstrings feature flag. However it is also very useful for normal operation. This commit changes the action to be valid, and adds tests for this scenario.
glennsarti
force-pushed
the
add-aggregate-metadata
branch
from
cb5cf1a to
685ad8e
Compare
This commit changes the language server to use the default and workspace aggregate actions, but behind the puppetstrings feature. There are no test changes required.
glennsarti
changed the title
|
Self merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the tests use private instance methods to verify the object, however
the each_list method now does that. This commit changes the tests to use this
method instead.
Previously the metadata aggregate action could only be used with the
puppetstrings feature flag. However it is also very useful for normal operation.
This commit changes the action to be valid, and adds tests for this scenario.
This commit changes the language server to use the default and workspace
aggregate actions, but behind the puppetstrings feature. There are no test
changes required.