Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aggregate sidecar tasks #163

Closed
glennsarti opened this issue Aug 1, 2019 · 0 comments · Fixed by #162
Closed

Add aggregate sidecar tasks #163

glennsarti opened this issue Aug 1, 2019 · 0 comments · Fixed by #162
Assignees
@glennsarti
Milestone
0.21.0

Comments

@glennsarti
Copy link
Contributor

Previously, to get all metadata information, the sidecar would need to be called
multiple times, however, with the puppetstrings featureflag, we can now evaluate
the metadata all at once.

This issue will track the work to add aggregate tasks, to gather all of the information in one call.
@glennsarti glennsarti added this to the 0.21.0 milestone Aug 1, 2019
@glennsarti glennsarti self-assigned this Aug 1, 2019
@glennsarti glennsarti mentioned this issue Aug 1, 2019
Merged
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Aug 1, 2019
@glennsarti
(puppetlabsGH-163) Add AggregateMetadata sidecar protocol object
3b2bf01 
Previously, to get all metadata information, the sidecar would need to be called
multiple times, however, with the puppetstrings featureflag, we can now evaluate
the metadata all at once.

This commit adds a new object called AggregateMetadata which can hold all of the
metadata objects (classes etc.) This commit also adds tests to ensure that it
can be serialised and deserialised correctly.

And finally this commit changes the puppetstrings helper to use the new
aggregate instead of a standard hashtable.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Aug 1, 2019
@glennsarti
(puppetlabsGH-163) Add aggregate sidecar tasks
7e6ac3b 
Previously the AggregateMetadata sidecar protocol object was added.  This commit
adds a default_aggregate and workspace_aggregate sidecar action which will
gather all of the metadata in one call. These actions will only be valid with
the puppetstrings featureflag.

This commt also adds integration tests for these new actions, with and without
the featureflag set.
glennsarti added a commit that referenced this issue Aug 1, 2019
@glennsarti
Merge pull request #162 from glennsarti/add-aggregate-metadata
5bdcc4f 
(GH-163) Add aggregate metadata sidecar object and tasks
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Aug 19, 2019
@glennsarti
(puppetlabsGH-163) Allow the aggregate to be used in all cases
34c01bf 
Previously the metadata aggregate action could only be used with the
puppetstrings feature flag.  However it is also very useful for normal operation.
This commit changes the action to be valid, and adds tests for this scenario.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Aug 19, 2019
@glennsarti
(puppetlabsGH-163) Allow the aggregate to be used in all cases
cb5cf1a 
Previously the metadata aggregate action could only be used with the
puppetstrings feature flag.  However it is also very useful for normal operation.
This commit changes the action to be valid, and adds tests for this scenario.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Aug 19, 2019
@glennsarti
(puppetlabsGH-163) Allow the aggregate to be used in all cases
685ad8e 
Previously the metadata aggregate action could only be used with the
puppetstrings feature flag.  However it is also very useful for normal operation.
This commit changes the action to be valid, and adds tests for this scenario.
glennsarti added a commit to glennsarti/puppet-editor-services that referenced this issue Aug 20, 2019
@glennsarti
(puppetlabsGH-163) Use the aggregate action for puppetstrings feature
376fc9e 
This commit changes the language server to use the default and workspace
aggregate actions, but behind the puppetstrings feature.  There are no test
changes required.
glennsarti added a commit that referenced this issue Aug 20, 2019
@glennsarti
Merge pull request #165 from glennsarti/add-aggregate-metadata
3511698 
(GH-163) Use aggregate metadata actions for puppetstrings feature flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glennsarti glennsarti

Labels
None yet
Projects
None yet
Milestone
0.21.0
Development

Successfully merging a pull request may close this issue.

(GH-163) Add aggregate metadata sidecar object and tasks glennsarti/puppet-editor-services
1 participant
@glennsarti