(maint) login_with_puppet_access_on should respect --lifetime flag (with spec tests)

[lucywyman]

No description provided.

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[puppetlabs-jenkins]

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/158/

[lucywyman]

The error here is

Error: Execution of '/usr/bin/apt-key adv --keyserver pgp.mit.edu --recv-keys 47B320EB4C7C375AA9DAE1A01054B7A24BD6EC30' returned 2: Executing: gpg --ignore-time-conflict --no-options --no-default-keyring --homedir /tmp/tmp.QAQ5hvktBS --no-auto-check-trustdb --trust-model always --keyring /etc/apt/trusted.gpg --primary-keyring /etc/apt/trusted.gpg --keyserver pgp.mit.edu --recv-keys 47B320EB4C7C375AA9DAE1A01054B7A24BD6EC30

which then causes

Error: /Stage[main]/Puppet_agent::Osfamily::Debian/Apt::Key[legacy key]/Apt_key[legacy key]/ensure: change from absent to present failed: Execution of '/usr/bin/apt-key adv --keyserver pgp.mit.edu --recv-keys 47B320EB4C7C375AA9DAE1A01054B7A24BD6EC30' returned 2: Executing: gpg --ignore-time-conflict --no-options --no-default-keyring --homedir /tmp/tmp.QAQ5hvktBS --no-auto-check-trustdb --trust-model always --keyring /etc/apt/trusted.gpg --primary-keyring /etc/apt/trusted.gpg --keyserver pgp.mit.edu --recv-keys 47B320EB4C7C375AA9DAE1A01054B7A24BD6EC30

I'm honestly not sure what to do about it, or what in my PR could have caused it. Giving up for today, will take a look in the morning.

[lucywyman]

@puppetlabs-jenkins retest this please

[puppetlabs-jenkins]

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/159/

[lucywyman]

@puppetlabs-jenkins retest this please

[puppetlabs-jenkins]

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-pe_btc-intn/163/

[jpartlow]

@lucywyman @tvpartytonight beaker-pe is a public repository, but scooter is private and internal to puppetlabs. By including it in the specs, the specs can't be run without access to the gem. I believe beaker-pe is public because there is some use of beaker to test PE installs outside of puppetlabs. I'm not certain if that still applies, @kevpl may know.

Probably should replace use of the Scooter::HttpDispatchers::ConsoleDispatcher with a double(:credentials => double(:login => 'foo', :password => 'bar'), :acquire_token_with_credentials => 'baz'), or resolve the public/private discrepancy between beaker-pe/scooter.

[tvpartytonight]

ahh, good catch @jpartlow . I have a ticket currently in RE's sprint to approve scooter for release to the general public. Is this issue something that we can wait on until that approval is done, or do we need to address this issue sooner?

[jpartlow]

@tvpartytonight Yes I think we should wait for that, and it's good to hear that Scooter is going public, since that simplifies using it more broadly in beaker-pe. I only ran into because I was running the specs and didn't have GEM_SOURCE declared locally.