(maint) login_with_puppet_access_on should respect --lifetime flag (w…

…ith spec tests) (#52)

* (maint) fix puppet access helper to respect lifetime argument

* (maint) Add spec tests for login_with_puppet_access_on

lib/beaker-pe/pe-client-tools/executable_helper.rb

@@ -75,7 +75,9 @@ def login_with_puppet_access_on(host, credentialed_dispatcher, opts={})
 
             user = credentialed_dispatcher.credentials.login
             password = credentialed_dispatcher.credentials.password
-            puppet_access_on(host, 'login', {:stdin => "#{user}\n#{password}\n"})
+            args = ['login']
+            args.push "--lifetime #{lifetime}" if lifetime
+            puppet_access_on(host, *args, {:stdin => "#{user}\n#{password}\n"})
           else
 
             # this is a hack

spec/beaker-pe/pe-client-tools/executable_helper_spec.rb

@@ -1,5 +1,6 @@
 require 'spec_helper'
 require 'beaker'
+require 'scooter'
 
 class MixedWithExecutableHelper
   include Beaker::DSL::PEClientTools::ExecutableHelper
@@ -9,7 +10,7 @@ class MixedWithExecutableHelper
 
   let(:method_name)   { "puppet_#{tool}_on"}
 
-  shared_examples 'pe-client-tool'do
+  shared_examples 'pe-client-tool' do
 
     it 'has a method to execute the tool' do
       expect(subject.respond_to?(method_name)).not_to be(false)
@@ -55,4 +56,28 @@ class MixedWithExecutableHelper
   it 'has a method to login with puppet access' do
     expect(subject.respond_to?('login_with_puppet_access_on')).not_to be(false)
   end
-end
+
+  context 'puppet access login with lifetime parameter' do
+    let(:logger) {Beaker::Logger.new}
+    let(:test_host) {Beaker::Host.create('my_super_host',
+                                         {:roles => ['master', 'agent'],
+                                          :platform => 'linux',
+                                          :type => 'pe'},
+                                          make_opts)}
+    let(:username) {'T'}
+    let(:password) {'Swift'}
+    let(:credentials) {{:login => username, :password => password}}
+    let(:test_dispatcher) {Scooter::HttpDispatchers::ConsoleDispatcher.new('my_super_host', credentials)}
+
+    before do
+      allow(logger).to receive(:debug) { true }
+      expect(test_dispatcher).to be_kind_of(Scooter::HttpDispatchers::ConsoleDispatcher)
+      expect(test_host).to be_kind_of(Beaker::Host)
+      expect(test_host).to receive(:exec)
+    end
+
+    it 'accepts correct value' do
+      expect{subject.login_with_puppet_access_on(test_host, test_dispatcher, {:lifetime => '5d'})}.not_to raise_error
+    end
+  end
+end