Allow ID to be dynamic #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My goal is to enable fixing pulumi/pulumi-cloudflare#709 by adding a Pulumi YAML check, since we are standardizing on writing test programs in YAML when possible. Fixes #562
iwahbe
force-pushed
the
iwahbe/allow-dynamic-id-choice
branch
from
296a381 to
dec0201
Compare
iwahbe
added a commit
to pulumi/pulumi-cloudflare
that referenced
this pull request
Apr 4, 2024
Fixes #709 This is a TS test because it cannot currently be expressed in YAML (pulumi/pulumi-yaml#562). When a version of Pulumi YAML releases with pulumi/pulumi-yaml#563, we can rewrite the test in YAML and incorporate it in our upgrade framework, making it _just another test_ like those in #719.
AaronFriel
approved these changes
Apr 10, 2024
Zaid-Ajaj
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach Pulumi YAML how to handle dynamic
get.idvalues.My goal is to enable fixing pulumi/pulumi-cloudflare#709 by adding a Pulumi YAML check, since we are standardizing on writing test programs in YAML when possible.
Fixes #562