Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup regression test for https://github.com/pulumi/pulumi-cloudflare/issues/554 #709

Closed
iwahbe opened this issue Apr 2, 2024 · 2 comments · Fixed by #721
Closed
Assignees
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@iwahbe
Copy link
Member

iwahbe commented Apr 2, 2024

#554

@iwahbe iwahbe self-assigned this Apr 2, 2024
@iwahbe
Copy link
Member Author

iwahbe commented Apr 2, 2024

This Pulumi program reproduces the panic:

import * as pulumi from "@pulumi/pulumi";
import * as cloudflare from "@pulumi/cloudflare";

const zone = cloudflare.getZoneOutput({
  accountId: new pulumi.Config().require("cloudflare-account-id"),
  name: "pulumi-cloudflare-demo.com",
})

const ruleset = new cloudflare.Ruleset("domain-rate-limit", {
  name: "domain-rate-limit",
  kind: "zone",
  zoneId: zone.zoneId,
  phase: "http_request_transform",

  rules: [{
    action: "rewrite",
    actionParameters: {
      uri: {
        path: {
          value: "/my-new-route"
        }
      }
    },

    expression: "(http.host eq \"example.com\" and http.request.uri.path eq \"/old-path\")",
    description: "example URI path transform rule",
    enabled: true,
  }],
});

export const importName = pulumi.interpolate`zone/${zone.id}/${ruleset.id}`;

cloudflare.Ruleset.get("imported", importName);

iwahbe added a commit to pulumi/pulumi-yaml that referenced this issue Apr 3, 2024
My goal is to enable fixing pulumi/pulumi-cloudflare#709 by
adding a Pulumi YAML check, since we are standardizing on writing test programs in YAML
when possible.

Fixes #562
iwahbe added a commit to pulumi/pulumi-yaml that referenced this issue Apr 3, 2024
My goal is to enable fixing pulumi/pulumi-cloudflare#709 by
adding a Pulumi YAML check, since we are standardizing on writing test programs in YAML
when possible.

Fixes #562
iwahbe added a commit that referenced this issue Apr 4, 2024
iwahbe added a commit that referenced this issue Apr 4, 2024
Fixes #709

This is a TS test because it cannot currently be expressed in YAML
(pulumi/pulumi-yaml#562).

When a version of Pulumi YAML releases with
pulumi/pulumi-yaml#563, we can rewrite the test
in YAML and incorporate it in our upgrade framework, making it _just
another test_ like those in
#719.
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Apr 4, 2024
@pulumi-bot pulumi-bot reopened this Apr 4, 2024
@pulumi-bot
Copy link
Contributor

Cannot close issue:

  • does not have required labels: kind/

Please fix these problems and try again.

@iwahbe iwahbe added the kind/engineering Work that is not visible to an external user label Apr 6, 2024
@iwahbe iwahbe closed this as completed Apr 6, 2024
iwahbe added a commit to pulumi/pulumi-yaml that referenced this issue Apr 11, 2024
* Allow ID to be dynamic

My goal is to enable fixing pulumi/pulumi-cloudflare#709 by
adding a Pulumi YAML check, since we are standardizing on writing test programs in YAML
when possible.

Fixes #562

* Update CHANGELOG_PENDING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants