Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve live tailing. #1898

Merged
merged 5 commits into from
May 2, 2022
Merged

Improve live tailing. #1898

merged 5 commits into from
May 2, 2022

Conversation

simonyandev
Copy link
Contributor

@simonyandev simonyandev commented Apr 25, 2022 •
edited
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

  1. While live mode is on (active loading) all the controls (search, offset, partitions select) will be disabled.
  2. Once "stop loading" is pressed, fetched messages do not disappear, and controls are enabled back again.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@simonyandev simonyandev added type/enhancement En enhancement to an already existing feature scope/frontend labels Apr 25, 2022
@simonyandev simonyandev requested a review from a team as a code owner April 25, 2022 11:07
@simonyandev simonyandev self-assigned this Apr 25, 2022
@simonyandev simonyandev linked an issue Apr 25, 2022 that may be closed by this pull request
Live tailing improvements #1740
Closed
Mgrdich
Mgrdich reviewed Apr 25, 2022
View reviewed changes
Copy link
Contributor

@Mgrdich Mgrdich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding test suites for MultiSelect.styled.ts to incorporate the props passing. will actually makes the sonar test 100%.

@Haarolean Haarolean added the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Apr 26, 2022
@github-actions
Copy link

Custom deployment will be available at http://enhancement-live-tailing-improve.internal.kafka-ui.provectus.io

@Haarolean
Copy link
Contributor

@simonyandev let's disable "submit" button as well, until "stop loading" is clicked.

@simonyandev simonyandev requested a review from Mgrdich April 27, 2022 10:23
@Haarolean Haarolean added status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. and removed status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. labels Apr 27, 2022
@github-actions
Copy link

Custom deployment removed

@github-actions
Copy link

Custom deployment will be available at http://enhancement-live-tailing-improve.internal.kafka-ui.provectus.io

@Haarolean Haarolean removed the status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. label Apr 28, 2022
@Haarolean Haarolean self-requested a review April 28, 2022 13:59
@github-actions
Copy link

Custom deployment removed

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@simonyandev simonyandev merged commit 521ba0c into master May 2, 2022
@simonyandev simonyandev deleted the enhancement/live-tailing-improvements branch May 2, 2022 06:05
simonyandev added a commit that referenced this pull request May 3, 2022
@simonyandev
Improve live tailing. (#1898)
58724cb 
* disable filter options when live tailing mode is enabled

* prevent seek direction change when stop loading is pressed on live mode

* disable submit button while tailing

* write tests for MultiSelect.styled component to achieve 100% coverage
simonyandev added a commit that referenced this pull request May 3, 2022
@simonyandev
Improve live tailing. (#1898)
415d852 
* disable filter options when live tailing mode is enabled

* prevent seek direction change when stop loading is pressed on live mode

* disable submit button while tailing

* write tests for MultiSelect.styled component to achieve 100% coverage
javalover123 pushed a commit to javalover123/kafka-ui that referenced this pull request Dec 7, 2022
@simonyandev
Improve live tailing. (provectus#1898)
bc87957 
* disable filter options when live tailing mode is enabled

* prevent seek direction change when stop loading is pressed on live mode

* disable submit button while tailing

* write tests for MultiSelect.styled component to achieve 100% coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workshur workshur workshur approved these changes

@Haarolean Haarolean Haarolean approved these changes

@rAzizbekyan rAzizbekyan rAzizbekyan approved these changes

@lazzy-panda lazzy-panda Awaiting requested review from lazzy-panda

@Mgrdich Mgrdich Awaiting requested review from Mgrdich

Assignees

@simonyandev simonyandev

Labels
scope/frontend type/enhancement En enhancement to an already existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Live tailing improvements
5 participants
@simonyandev @Haarolean @workshur @Mgrdich @rAzizbekyan