Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live tailing improvements #1740

Closed
Haarolean opened this issue Mar 20, 2022 · 1 comment · Fixed by #1774, #1824 or #1898
Closed

Live tailing improvements #1740

Haarolean opened this issue Mar 20, 2022 · 1 comment · Fixed by #1774, #1824 or #1898
Assignees
@simonyandev
Labels
good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted type/enhancement En enhancement to an already existing feature
Milestone
0.4

Comments

@Haarolean
Copy link
Contributor

Haarolean commented Mar 20, 2022 •
edited by iliax
Loading

  1. New messages should appear on top
  2. Pagination buttons (e.g. "Next") shouldn't be visible.

wrong parameters passed for live tailing:
https://www.kafka-ui.provectus.io/api/clusters/local/topics/7890/messages?filterQueryType=STRING_CONTAINS&attempt=1&limit=100&seekDirection=TAILING&seekType=OFFSET&seekTo=0::0

this should be https://www.kafka-ui.provectus.io/api/clusters/local/topics/7890/messages&seekDirection=TAILING&seekType=LATEST&seekTo=0::0

seekType should be LATEST
attempt has no effect (can be removed from all endpoints)
limit has no effect in TAILING mode
(not critical) filterQueryType make sense only when q param passed
seekTo should be 0::0,1::0,... where first number is partition

#943
@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted labels Mar 20, 2022
@Haarolean Haarolean added this to the 0.4 milestone Mar 20, 2022
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Mar 20, 2022
@Haarolean Haarolean removed the status/triage Issues pending maintainers triage label Mar 20, 2022
@Haarolean Haarolean linked a pull request Mar 29, 2022 that will close this issue
Issues/1740 live tailing improvements #1774
Merged
13 tasks
@Haarolean Haarolean reopened this Apr 7, 2022
@Mgrdich Mgrdich linked a pull request Apr 12, 2022 that will close this issue
Issues/1740 live tailing order #1824
Merged
13 tasks
@Haarolean Haarolean reopened this Apr 25, 2022
@Haarolean
Copy link
Contributor Author

  1. While live mode is on (active loading) all the controls (search, offset, partitions select) should be disabled.
  2. Once "stop loading" is pressed, fetched messages should NOT disappear. And controls (p. 1) should be enabled back again.

@simonyandev simonyandev linked a pull request Apr 25, 2022 that will close this issue
Improve live tailing. #1898
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonyandev simonyandev

Labels
good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted type/enhancement En enhancement to an already existing feature
Projects
None yet
Milestone
0.4
3 participants
@Haarolean @Mgrdich @simonyandev