-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc maven artifacts: reuse osx-x86_64 for osx-aarch_64 #8557
Conversation
Signed-off-by: James Yuzawa <[email protected]>
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Just a workaround. Track grpc/grpc-java#7690 and protocolbuffers/protobuf#8557 for permanent fix
@perezd Could you look over this MR quickly? I think the review is going pretty fast here and many could benefit from it. |
The checks say the PR is missing a label, which I cannot add, so can the admins please add one (maybe |
He is on vacation at the moment, but I reviewed it. |
Fixed by protocolbuffers/protobuf#8557 in protocolbuffers/protobuf#8695 Full Apple Silicon blocked by terl/lazysodium-java#107
* versions from 3.17.3 upwards support the Mac M1 architecture (osx-aarch_64), and allow native usage of sbt on a Mac M1, see protocolbuffers/protobuf#8557
These are still x86-64 binaries at the moment (see protocolbuffers#8557), but should be usable on M1 Macs in the Rosetta compatibility mode. Let's start publishing them on our GitHub release page and then eventually we can make them into true x86-64 binaries. This fixes protocolbuffers#9200.
These are still x86-64 binaries at the moment (see protocolbuffers#8557), but should be usable on M1 Macs in the Rosetta compatibility mode. Let's start publishing them on our GitHub release page and then eventually we can make them into true aarch_64 binaries. This fixes protocolbuffers#9200.
Could this approach be backported to latest 2.x release? |
I ran into this issue, and the following fixed it for me. softwareupdate --install-rosetta This allows for Macs with M1 chips to run in Intel compatibility mode. |
jacky@jacky-mac Downloads % ./protoc-gen-grpc-java-osx-aarch_64.exe can not executable on mac m2 chips |
@JackyAnn, that is grpc/grpc-java#7690 |
Thank you @ejona86 |
Fixes google/protobuf-gradle-plugin#492
The main rationale is to fix this and not have users need to manually and/or conditionally point at the x86_64 classifier. The M1 macs are able to run x86_64 binaries in rosetta compatibility mode.
@ejona86 had a good idea, so I attempt here to upload the same file used in the osx-x86_64 classifier for the osx-aarch_64 classifier.
One day if a native M1 build comes along and solves this, modify this to upload a real M1 build.