Add support for constant keys in our Mapping type #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
simu
force-pushed
the
feat/mapping-const-keys
branch
2 times, most recently
from
e4c3432 to
c8615c8
Compare
We implement handling of constant keys (keys prefixed with `KeyPrefix::Constant`) directly in the Mapping implementation. Keys with other prefixes are inserted into the map unchanged. To make the implementation more streamlined (and potentially faster), we switch the type of `const_keys` to be a `HashSet` instead of a `Vec`, which gives us `O(1)` removal of elements (for `Mapping::remove()`). To insure integrity of the constant key tracking, We remove the `map_as_mut()` method on the Mapping implementation which would allow callers to break the constant key invariants that the other functions provide. Some functions (`insert`, `get_mut`, and `entry`) will return an Error value when called for a key that's marked constant.
simu
force-pushed
the
feat/mapping-const-keys
branch
from
c8615c8 to
ac8b8ac
Compare
simu
changed the title
bastjan
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement handling of constant keys (keys prefixed with
KeyPrefix::Constant) directly in the Mapping implementation. Keys with other prefixes are inserted into the map unchanged.To make the implementation more streamlined (and potentially faster), we switch the type of
const_keysto be aHashSetinstead of aVec, which gives usO(1)removal of elements (forMapping::remove()).To insure integrity of the constant key tracking, We remove the
map_as_mut()method on the Mapping implementation which would allow callers to break the constant key invariants that the other functions provide.Some functions (
insert,get_mut, andentry) will return an Error value when called for a key that's marked constant.Follow-up to #8
Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog