Implement custom Mapping and Value types
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
feat/custom-parameters-types
branch
from
1e24aaa to
d045b79
Compare
simu
commented
Aug 31, 2023
We introduce our own `Mapping` and `Value` types which are compatible with `serde_yaml`'s types, but provide extra state and functionality for handling the Reclass parameters Mapping.
We already introduce `Value::variant()` and `Value::strip_prefix` which we'll use when implementing Reclass parameter merging.
simu
force-pushed
the
feat/custom-parameters-types
branch
from
d045b79 to
0870274
Compare
6 tasks
simu
commented
Sep 1, 2023
6 tasks
bastjan
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces custom
MappingandValuetypes which are compatible withserde_yaml's types, but provide extra state and functionality for handling the Reclass parameters Mapping.The PR updates the Node parsing implementation to convert the raw parsed
parametersinto our customMappingtype, and moves the logic which injects the_reclass_meta parameter from the raw serde_yaml parameters Mapping to the customMapping.Additionally, we move the
as_py_dict()andas_py_obj()methods to the customMappingandValuetypes respectivey, and remove the variants which take serde_yaml types as parameters.Finally, we update
NodeInfoto use the customMappingtype forparameters.Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog