Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace wellknown filter names with typed config #2479

Closed
jpeach opened this issue Apr 29, 2020 · 7 comments · Fixed by #3127
Closed

Replace wellknown filter names with typed config #2479

jpeach opened this issue Apr 29, 2020 · 7 comments · Fixed by #3127
Assignees
@stevesloka
Milestone
1.11.0

Comments

@jpeach
Copy link
Contributor

jpeach commented Apr 29, 2020

The go-control-plane constants for well-known filters use the deprecated filter names. Contour should switch over to using typed config for these in case some future Envoy version removes the deprecated names.

xref: envoyproxy/go-control-plane#293
@stevesloka
Copy link
Member

I just ran into this as well, I can take and update it.

@stevesloka stevesloka self-assigned this Apr 29, 2020
@stevesloka stevesloka added this to the 1.5.0 milestone Apr 29, 2020
@jpeach
Copy link
Contributor Author

jpeach commented Apr 29, 2020

I just ran into this as well, I can take and update it.

Cool! Also see https://envoyproxy.slack.com/archives/CEFDKQ3RQ/p1588129018117000

@stevesloka
Copy link
Member

Example logs:

[2020-04-29 22:07:24.797][1][warning][misc] [source/common/protobuf/utility.cc:198] Using deprecated option 'envoy.config.filter.network.http_connection_manager.v2.HttpFilter.config' from file http_connection_manager.proto. Th
is configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/intro/deprecated for details.
[2020-04-29 22:07:24.798][1][warning][misc] [bazel-out/k8-opt/bin/source/extensions/common/_virtual_includes/utility_lib/extensions/common/utility.h:65] Using deprecated extension name 'envoy.gzip' for 'envoy.filters.http.gzip
'. This name will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/intro/deprecated for details.
[2020-04-29 22:07:24.798][1][warning][misc] [bazel-out/k8-opt/bin/source/extensions/common/_virtual_includes/utility_lib/extensions/common/utility.h:65] Using deprecated extension name 'envoy.grpc_web' for 'envoy.filters.http.
grpc_web'. This name will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/intro/deprecated for details.
[2020-04-29 22:07:24.798][1][warning][misc] [bazel-out/k8-opt/bin/source/extensions/common/_virtual_includes/utility_lib/extensions/common/utility.h:65] Using deprecated extension name 'envoy.router' for 'envoy.filters.http.ro
uter'. This name will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/intro/deprecated for details.
[2020-04-29 22:07:24.799][1][warning][config] [source/common/config/grpc_subscription_impl.cc:101] gRPC config for type.googleapis.com/envoy.api.v2.Listener rejected: Error adding/updating listener(s) ingress_http: Error: term
inal filter named envoy.router of type envoy.filters.http.router must be the last filter in a http filter chain.

@stevesloka
Copy link
Member

The link in the error message 404s, here's the deprecation notes: https://www.envoyproxy.io/docs/envoy/v1.14.1/intro/deprecated.html?highlight=deprecated#april-8-2020

@stevesloka
Copy link
Member

Blocked on envoyproxy/go-control-plane#294

@stevesloka stevesloka added blocked Blocked waiting on a dependency blocked/needs-envoy Categorizes the issue or PR as blocked because it needs changes in Envoy. labels Apr 30, 2020
@jpeach
Copy link
Contributor Author

jpeach commented Apr 30, 2020

@stevesloka The suggestion here was to use typed config (which doesn't change) rather than the filter names. Apparently, envoy will infer the name typed config URL.

@jpeach jpeach modified the milestones: 1.5.0, Backlog May 28, 2020
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 18, 2020
@stevesloka
deps: update go-control-plane to v0.9.6
ee1d6ce 
Updates the go-control-plane dep which fixes up a bunch of wellknown name types.

Updates projectcontour#2479

Signed-off-by: Steve Sloka <[email protected]>
@stevesloka
Copy link
Member

//cc envoyproxy/go-control-plane#354

stevesloka added a commit to stevesloka/contour that referenced this issue Sep 18, 2020
@stevesloka
internal/envoy: Update GZip to valid wellknown name
83aed21 
Updates: projectcontour#2479

Signed-off-by: Steve Sloka <[email protected]>
This was referenced Sep 18, 2020
Closed
Merged
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 18, 2020
@stevesloka
deps: update go-control-plane to v0.9.6
db07ca0 
Updates the go-control-plane dep which fixes up a bunch of wellknown name types.
Also changes how the node_version is used since the previous method is deprecated.

Updates projectcontour#2479

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 18, 2020
@stevesloka
internal/envoy: Update GZip to valid wellknown name
5eaaf79 
Updates: projectcontour#2479

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Sep 18, 2020
@stevesloka
internal/envoy: Update GZip to valid wellknown name
7030a05 
Updates: projectcontour#2479

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit that referenced this issue Sep 18, 2020
@stevesloka
deps: update go-control-plane to v0.9.6 (#2927)
05997b6 
Updates the go-control-plane dep which fixes up a bunch of wellknown name types.
Also changes how the node_version is used since the previous method is deprecated.

Updates #2479

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 13, 2020
@stevesloka
internal/envoy: moved to typed configs for httpfilters
1679dc7 
Using some HTTP filter names from the go-control-plane wellknown package give warnings
due to being deprecated from Envoy.

This updates the names to use TypedConfigs which are matched differently in Envoy
and won't have the same issues with deprecation.

Fixes projectcontour#2479

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 13, 2020
@stevesloka
internal/envoy: moved to typed configs for httpfilters
9fb3eba 
Using some HTTP filter names from the go-control-plane wellknown package give warnings
due to being deprecated from Envoy.

This updates the names to use TypedConfigs which are matched differently in Envoy
and won't have the same issues with deprecation.

Fixes projectcontour#2479

Signed-off-by: Steve Sloka <[email protected]>
@stevesloka stevesloka mentioned this issue Nov 13, 2020
Merged
@stevesloka stevesloka removed blocked Blocked waiting on a dependency blocked/needs-envoy Categorizes the issue or PR as blocked because it needs changes in Envoy. labels Nov 13, 2020
@skriss skriss modified the milestones: Backlog, 1.11.0 Nov 16, 2020
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 16, 2020
@stevesloka
internal/envoy: moved to typed configs for httpfilters
3409330 
Using some HTTP filter names from the go-control-plane wellknown package give warnings
due to being deprecated from Envoy.

This updates the names to use TypedConfigs which are matched differently in Envoy
and won't have the same issues with deprecation.

Fixes projectcontour#2479

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit to stevesloka/contour that referenced this issue Nov 16, 2020
@stevesloka
internal/envoy: moved to typed configs for httpfilters
9a63e7c 
Using some HTTP filter names from the go-control-plane wellknown package give warnings
due to being deprecated from Envoy.

This updates the names to use TypedConfigs which are matched differently in Envoy
and won't have the same issues with deprecation.

Fixes projectcontour#2479

Signed-off-by: Steve Sloka <[email protected]>
stevesloka added a commit that referenced this issue Nov 16, 2020
@stevesloka
internal/envoy: moved to typed configs for httpfilters (#3127)
3f387fb 
Using some HTTP filter names from the go-control-plane wellknown package give warnings
due to being deprecated from Envoy.

This updates the names to use TypedConfigs which are matched differently in Envoy
and won't have the same issues with deprecation.

Fixes #2479

Signed-off-by: Steve Sloka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevesloka stevesloka

Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

Successfully merging a pull request may close this issue.

internal/envoy: moved to typed configs for httpfilters stevesloka/contour
3 participants
@jpeach @stevesloka @skriss