Wellknown filter names are deprecated #293
Comments
|
Just curious - does the merge of #294 resolve this issue? |
|
Protobuf type takes precedence, so the name is not important as of last couple of releases of Envoy. |
|
Cool, thanks for the info. Can we close this issue? |
|
Yeah, let's close it. The action item is just to document. |
|
On 30 Jul 2020, at 8:59 am, Kuat ***@***.***> wrote:
Yeah, let's close it. The action item is just to document.
Would you take a PR documenting the names as deprecated and recommending use of the type URLs?
|
Absolutely. |
at least not in 1.12 :) |
shashankram
added a commit
to shashankram/osm
that referenced
this issue
Jun 21, 2022
- Updates Envoy to its latest available version (v1.22.2 for Linux, v1.22.1 for Windows). The latest version includes the latest released security fix. We could not update Envoy previously due to a blocking bug: envoyproxy/envoy#20113 - Updates filter names to custom names as wellknown names are deprecated in Envoy (with 1 exception for the http.rbac filter). Envoy will use the TypeURL in the proto to determine which filter to use instead. Wellknown names are not required and using them is confusing because not all filters are defined in the legacy wellknown pkg (e.g. http.local_ratelimit). See: envoyproxy/envoy#21759 envoyproxy/envoy#21763 envoyproxy/go-control-plane#293 envoyproxy/go-control-plane#552 - Uses the distroless image as the alpine image has been discontinued: envoyproxy/envoy#21758 - Updates tests to use custom filter names - Adds `proto_types.go` to aid dynamic proto resolution for typed configs using `any.Any()`. This helps resolve protos where dynamic resolution is necessary. - Updated Prometheus' ConfigMap to reflect changes to Envoy metrics prefixes Signed-off-by: Shashank Ram <[email protected]>
shashankram
added a commit
to openservicemesh/osm
that referenced
this issue
Jun 22, 2022
- Updates Envoy to its latest available version (v1.22.2 for Linux, v1.22.1 for Windows). The latest version includes the latest released security fix. We could not update Envoy previously due to a blocking bug: envoyproxy/envoy#20113 - Updates filter names to custom names as wellknown names are deprecated in Envoy (with 1 exception for the http.rbac filter). Envoy will use the TypeURL in the proto to determine which filter to use instead. Wellknown names are not required and using them is confusing because not all filters are defined in the legacy wellknown pkg (e.g. http.local_ratelimit). See: envoyproxy/envoy#21759 envoyproxy/envoy#21763 envoyproxy/go-control-plane#293 envoyproxy/go-control-plane#552 - Uses the distroless image as the alpine image has been discontinued: envoyproxy/envoy#21758 - Updates tests to use custom filter names - Adds `proto_types.go` to aid dynamic proto resolution for typed configs using `any.Any()`. This helps resolve protos where dynamic resolution is necessary. - Updated Prometheus' ConfigMap to reflect changes to Envoy metrics prefixes Signed-off-by: Shashank Ram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Any program using the
wellknownpackage constants for filter names will run into the problem that these filter names are deprecated in Envoy. However, just changing to the new names seems hard because the API might be used by programs that server older versions of Envoy that don't support the new names.The text was updated successfully, but these errors were encountered: