Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NPM build step inside of client variant logic inside of build_example #1175

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

jul-sh
Copy link
Contributor

@jul-sh jul-sh commented Jun 19, 2020

Checklist

  • Pull request affects core Oak functionality (e.g. runtime, SDK, ABI)
    • I have written tests that cover the code changes.
    • I have checked that these tests are run by
      Cloudbuild
    • I have updated documentation accordingly.
    • I have raised an issue to
      cover any TODOs and/or unfinished work.
  • Pull request includes prototype/experimental work that is under
    construction.

@jul-sh jul-sh changed the title Bash build npm Move NPM build step inside of client variant logic inside of build_example Jun 19, 2020
@jul-sh
Copy link
Contributor Author

jul-sh commented Jun 19, 2020

@anghelcovici

Thanks for your comment! Most of the code in this draft PR (the first commit) actually was PR'ed in #1170 & merged earlier.

I left this PR in draft as further work, but it's not fully ready yet. The aspect this PR will address specifically is into the client variant in the build_example step. :)

@jul-sh jul-sh force-pushed the bash_build_npm branch 2 times, most recently from ae90542 to ac3c4a8 Compare June 19, 2020 12:38
@jul-sh jul-sh marked this pull request as ready for review June 24, 2020 11:33
@jul-sh jul-sh merged commit 5f44058 into project-oak:main Jun 24, 2020
@jul-sh jul-sh deleted the bash_build_npm branch June 24, 2020 14:22
@github-actions
Copy link

Reproducibility Index:

e1c5b8b551b683e7c3c12346ba65dad9ab184abac9d59d3c605ae5a7a5aa7895  ./examples/target/wasm32-unknown-unknown/release/abitest_0_frontend.wasm
e89bb8621965e356156c939997a61fa1af30352159ae9e7a59f50a8eb101648d  ./examples/target/wasm32-unknown-unknown/release/abitest_1_backend.wasm
b256b1c1402a8f25381352047ee48cc9a07314d4227a64bd786369a17c61d1df  ./examples/target/wasm32-unknown-unknown/release/aggregator.wasm
44eff10ce70a232c84cc32c225e75eca695634abc9ecfbf543022aa0a5682cd7  ./examples/target/wasm32-unknown-unknown/release/chat.wasm
b28dc802af588ea6512974d2d9ec17557dd454f760b379ab80b11efbe444ecfd  ./examples/target/wasm32-unknown-unknown/release/hello_world.wasm
1123ddd109dd00155b0f59ccc2f3025974bacc82e15a4d1fe2a83ff6ceb2b3cd  ./examples/target/wasm32-unknown-unknown/release/machine_learning.wasm
66ae9e10c2d72cab7e629b2fea2ae98939649c391480ab255d589f5da8c7ae0f  ./examples/target/wasm32-unknown-unknown/release/private_set_intersection.wasm
0cd8cb0baae0c59852e775a697ca5408f975c1c1fdc53cc8f3a0e7d07e23f5af  ./examples/target/wasm32-unknown-unknown/release/running_average.wasm
15da62b4701e02ae731276dbe8bdfd29805871e7f863e8e15b1fe11983023159  ./examples/target/wasm32-unknown-unknown/release/translator.wasm
571d966c66ebf487d1f07ae0aba89fe22bcf8d09fcd861a490aec215c4b94aa9  ./examples/target/wasm32-unknown-unknown/release/trusted_information_retrieval.wasm
316d402713bec5c83d5583e21aa73b1b4f36a7d3be4e96cd0759c93a8bcb2ae0  ./oak/server/target/x86_64-unknown-linux-musl/release/oak_loader

Reproducibility Index diff:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants