-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build scripts: Name client variants by their build system for clarity #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jul-sh
commented
Jun 18, 2020
scripts/run_example
Outdated
Comment on lines
126
to
127
bazel) | ||
cpp_client="${SCRIPTS_DIR}/../examples/${EXAMPLE}/client/BUILD" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also means we now explicitly check for the presence of a BUILD file.
e8619e1
to
7193d30
Compare
41e2a13
to
7230c33
Compare
daviddrysdale
approved these changes
Jun 19, 2020
7230c33
to
9a8de65
Compare
6 tasks
Reproducibility Index:
Reproducibility Index diff: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
cpp
->bazel
rust
->cargo
nodejs
->npm
Addresses @daviddrysdale's earlier comment: #1169 (comment)
This renames the issue of the somewhat confusing
cpp
variant.This makes sense, since bazel is the build system the scripts will use for this variant. And other non cpp clients (Go) that use bazel shouldn't use the
cpp
flag.Similarly this renames
rust
tocargo
, andnodejs
tonpm
, so we always refer to the build system.This is quite similar to the naming used in the rust runner.
oak/runner/src/main.rs
Line 295 in 19ff6bb
Imho it might be worth to think about doing the same for the server/application variants.
Checklist
Cloudbuild
cover any TODOs and/or unfinished work.
construction.