New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the hello world nodejs client in our CI #1147

Merged

jul-sh merged 1 commit into project-oak:master from jul-sh:runnode

Jun 12, 2020

Contributor

jul-sh commented Jun 12, 2020

Will follow this up with a PR that integrates examples with multiple clients in a more optimized manner.
See the issue linked in the Todo: #1145

Checklist

Pull request affects core Oak functionality (e.g. runtime, SDK, ABI)
- I have written tests that cover the code changes.
- I have checked that these tests are run by
  Cloudbuild
- I have updated documentation accordingly.
- I have raised an issue to
  cover any TODOs and/or unfinished work.
Pull request includes prototype/experimental work that is under
construction.

jul-sh requested review from tiziano88 and daviddrysdale

June 12, 2020 10:39

googlebot added the cla: yes label

jul-sh requested a review from ipetr0v

June 12, 2020 10:40


          Run the hello world nodejs client in our CI

49297fb

jul-sh force-pushed the runnode branch from 29a1498 to 49297fb Compare

June 12, 2020 10:42

ipetr0v approved these changes

View reviewed changes

jul-sh merged commit 5ad2cd7 into project-oak:master

jul-sh deleted the runnode branch

July 16, 2020 14:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels