Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support examples with multiple clients in our CI scripts #1145

Closed
jul-sh opened this issue Jun 12, 2020 · 5 comments
Closed

Support examples with multiple clients in our CI scripts #1145

jul-sh opened this issue Jun 12, 2020 · 5 comments

Comments

@jul-sh
Copy link
Contributor

jul-sh commented Jun 12, 2020

Examples can have applications in multiple languages, as well as multiple clients (eg hello_world, which features cpp, Android, Node.js or Trusted Information Retrieval featuring cpp + Rust).

Ideally our scripts should make it easy to run an optimal combination of these in our CI.

@jul-sh
Copy link
Contributor Author

jul-sh commented Jun 12, 2020

My idea would be to enable passing a -c all flag to scripts/run_examples. Which would run all available clients for each example.

We could then decide to run all clients for only the cpp applications (faster), or decide to run all clients for each application variant (more exhaustive).

@jul-sh
Copy link
Contributor Author

jul-sh commented Jun 12, 2020

cc @ipetr0v, I am curious how the Rust Trusted Information Retrieval example handles this. It seems we only run the Rust client now? https://github.com/project-oak/oak/pull/1110/files#r439337221

@ipetr0v
Copy link
Contributor

ipetr0v commented Jun 12, 2020

Right now, yes, it only runs a Rust client.
But -c all looks nice. Or we can always run all clients by default, and -c ... will just specify and restrict clients. Or it can read a list of languages like -c cpp rust go nodejs .

@jul-sh
Copy link
Contributor Author

jul-sh commented Jun 12, 2020

I like running all clients by default, seems sensible to me :)

@jul-sh
Copy link
Contributor Author

jul-sh commented Jun 15, 2020

Closing as my PR was merged

@jul-sh jul-sh closed this as completed Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants