Adopt a Project-consistent Two-level #include Directive Name Pattern for the System Layer Library #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerickson
requested review from
anush-apple,
BroderickCarlin,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
tpmanley and
woody-apple
as code owners
|
LGTM, but just curious, is reducing the -I directives the primary purpose of this? |
Not reducing per se but making those that are required consistent from subsystem and module to subsystem and module. If reduction happens as a side-effect, that's a bonus. When this project is closer to done, my goal for a consumer of the SDK would be to add two compiler / linker options to his / her command line for headers and libraries:
and for every public API header for the CHIP SDK to be of the form: Less IdealMore Ideal |
|
lgtm we had undone this because we didn't have "dist" in the make system at project kickoff |
woody-apple
approved these changes
Apr 2, 2020
BroderickCarlin
approved these changes
Apr 2, 2020
|
@hawk248 or @jelderton? |
jelderton
approved these changes
Apr 2, 2020
mkardous-silabs
referenced
this pull request
in mkardous-silabs/connectedhomeip
Nov 2, 2022
…aviour with the app UI (project-chip#23331)" from silabs to silabs_1.0 Merge in WMN_TOOLS/matter from cherry-pick/fix_autorelock to silabs_1.0 Squashed commit of the following: commit 76df32b2d0e6c627545656d9e675c33825f2dab9 Author: jmartinez-silabs <[email protected]> Date: Wed Oct 26 17:16:25 2022 -0400 [EFR32] Link the door lock relock behaviour with the app UI (project-chip#23331) * Make the relock callback weak, implement it on the app side and link our app ui * address PR comments, Create a new functions that deal with the cluster and calls the application callback
rerasool
added a commit
to SiliconLabs/matter
that referenced
this pull request
Nov 2, 2022
…k relock behaviour with the app UI (project-chip#23331)" from silabs to silabs_1.0 Merge in WMN_TOOLS/matter from cherry-pick/fix_autorelock to silabs_1.0 Squashed commit of the following: commit 76df32b2d0e6c627545656d9e675c33825f2dab9 Author: jmartinez-silabs <[email protected]> Date: Wed Oct 26 17:16:25 2022 -0400 [EFR32] Link the door lock relock behaviour with the app UI (project-chip#23331) * Make the relock callback weak, implement it on the app side and link our app ui * address PR comments, Create a new functions that deal with the cluster and calls the application callback
Sarthak-Shaha
pushed a commit
to Sarthak-Shaha/connectedhomeip_silabs
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently most of the system layer library headers do not follow a two-level include name pattern used by the rest of the project.
Summary of Changes
Adopts a two-level #include directive name pattern for system layer library headers.
Fixes #220