Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure System Layer Library #include Directives Follow Two-level Pattern #220

Closed
gerickson opened this issue Apr 2, 2020 · 0 comments · Fixed by #221
Closed

Ensure System Layer Library #include Directives Follow Two-level Pattern #220

gerickson opened this issue Apr 2, 2020 · 0 comments · Fixed by #221
Assignees
@gerickson
Labels
enhancement New feature or request

Comments

@gerickson
Copy link
Contributor

Problem

Currently most of the system layer library headers do not follow a two-level include name pattern used by the rest of the project.

Proposed Solution

For the sake of both project consistency and to minimize the build -I options, ensure that system layer library headers follow such a pattern.
@gerickson gerickson added the enhancement New feature or request label Apr 2, 2020
@gerickson gerickson self-assigned this Apr 2, 2020
@gerickson gerickson mentioned this issue Apr 2, 2020
Merged
mkardous-silabs referenced this issue in mkardous-silabs/connectedhomeip Nov 2, 2022
@rerasool @jmartinez-silabs
Pull request #220: Cherry-Pick "EFR32 lock event generation using mat…
78b2c94 
…ter shell (project-chip#23248)" from silabs to silabs_1.0

Merge in WMN_TOOLS/matter from cherry-pick/lock_events to silabs_1.0

Squashed commit of the following:

commit 19de8e8d120abbcffdf199813e4e400f3cdb2b90
Author: Michael Rupp <[email protected]>
Date:   Fri Oct 21 18:42:40 2022 -0400

    EFR32 lock event generation using matter shell (project-chip#23248)

    * EFR32 lock event generation using matter shell

    code review comment cleanup

    * code review comments
rerasool added a commit to SiliconLabs/matter that referenced this issue Nov 2, 2022
@rerasool @jmartinez-silabs
Pull request project-chip#220: Cherry-Pick "EFR32 lock event generati…
28b28cc 
…on using matter shell (project-chip#23248)" from silabs to silabs_1.0

Merge in WMN_TOOLS/matter from cherry-pick/lock_events to silabs_1.0

Squashed commit of the following:

commit 19de8e8d120abbcffdf199813e4e400f3cdb2b90
Author: Michael Rupp <[email protected]>
Date:   Fri Oct 21 18:42:40 2022 -0400

    EFR32 lock event generation using matter shell (project-chip#23248)

    * EFR32 lock event generation using matter shell

    code review comment cleanup

    * code review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gerickson gerickson

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@gerickson