Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IM] Implement list chunking feature #12019

Merged
merged 17 commits into from
Dec 6, 2021
Merged

[IM] Implement list chunking feature #12019

merged 17 commits into from
Dec 6, 2021

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented Nov 19, 2021 •
edited
Loading

Problem

List chunking is not supported.

This PR relies on #11705 for passing all CI items.

Change overview

  • Add list chunking support
  • AttributeValueEncoder will encode the whole AttributeReportIB instead of a single Attribute value field now
  • Added a State class to persist state between encoding sessions (chunks)

Testing

  • Updated TestReadInteraction
  • Updated TestAttributeValueEncoder

@todo
Copy link

todo bot commented Nov 19, 2021

We should probably clone the writer and convert failures here

connectedhomeip/src/app/util/ember-compatibility-functions.cpp

Lines 225 to 235 in 47ba649

// TODO: We should probably clone the writer and convert failures here
// into status responses, unless our caller already does that.
AttributeValueEncoder::AttributeEncodeState state =
(apEncoderState == nullptr ? AttributeValueEncoder::AttributeEncodeState() : *apEncoderState);
AttributeValueEncoder valueEncoder(aAttributeReports, aAccessingFabricIndex, aPath, kTemporaryDataVersion, state);
CHIP_ERROR err = attrOverride->Read(aPath, valueEncoder);
if (err != CHIP_NO_ERROR)
{
// If the err is not CHIP_NO_ERROR, means the encoding was aborted, then the valueEncoder may save its state.
// The state is used by list chunking feature for now.

This comment was generated by todo based on a TODO comment in 47ba649 in #12019. cc @erjiaqing.

@bzbarsky-apple
Copy link
Contributor

And it looks like #12019 (comment) and #12019 (comment) might have been missed?

@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12019: Size comparison from 186c004 to 3bfb57b

Increases above 0.2%:

platform target config section 186c004 3bfb57b change % change
efr32 lighting-app BRD4161A (read only) 751672 758896 7224 1.0
.text 751664 758888 7224 1.0
BRD4161A+rpc (read only) 780344 787560 7216 0.9
.text 780336 787552 7216 0.9
lock-app BRD4161A (read only) 726496 733952 7456 1.0
.text 726488 733944 7456 1.0
window-app BRD4161A (read only) 729000 736224 7224 1.0
.text 728992 736216 7224 1.0
esp32 all-clusters-app c3devkit (read only) 847922 852542 4620 0.5
(read/write) 1222786 1290914 68128 5.6
.dram0.bss 55352 56352 1000 1.8
.flash.rodata 167920 169520 1600 1.0
.flash.text 847922 852542 4620 0.5
m5stack (read only) 918319 922407 4088 0.4
(read/write) 421756 424356 2600 0.6
.dram0.bss 60736 61736 1000 1.6
.flash.rodata 195724 197324 1600 0.8
.flash.text 912935 917023 4088 0.4
k32w lighting-app k32w061+se05x+release (read/write) 728696 731924 3228 0.4
.text 641724 644952 3228 0.5
lock-app k32w061+debug (read/write) 618736 622092 3356 0.5
.text 541132 544488 3356 0.6
shell k32w061+debug (read/write) 684644 687984 3340 0.5
.text 595420 598760 3340 0.6
linux all-clusters-app debug (read only) 1851521 1872937 21416 1.2
(read/write) 123344 124336 992 0.8
.bss 49680 50672 992 2.0
.rodata 151285 152117 832 0.5
.text 1557154 1577714 20560 1.3
bridge-app debug+rpc (read only) 1432645 1444405 11760 0.8
.text 1205797 1218005 12208 1.0
chip-tool debug .rodata 309912 310776 864 0.3
lighting-app debug+rpc (read only) 1717761 1729553 11792 0.7
.text 1432514 1444722 12208 0.9
ota-provider-app debug (read only) 1393289 1401065 7776 0.6
.text 1165810 1173522 7712 0.7
ota-requestor-app debug (read only) 1502561 1510321 7760 0.5
.text 1258418 1266082 7664 0.6
shell debug .rodata 84338 84658 320 0.4
tv-app debug (read only) 2031625 2046585 14960 0.7
.text 1701538 1717490 15952 0.9
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2307096 2313152 6056 0.3
.bss 178404 179404 1000 0.6
.text 1269672 1275728 6056 0.5
lighting-app CY8CPROTO_062_4343W+release .text 1258896 1261696 2800 0.2
lock-app CY8CPROTO_062_4343W+release .text 1232888 1235688 2800 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 894895 3180 0.4
text 602824 605904 3080 0.5
nrf52840dk_nrf52840+rpc (read/write) 855091 858255 3164 0.4
text 577820 580900 3080 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 817610 820790 3180 0.4
text 533156 536240 3084 0.6
lock-app nrf52840dk_nrf52840 (read/write) 863639 866915 3276 0.4
text 581540 584716 3176 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 789794 793050 3256 0.4
text 511964 515140 3176 0.6
pump-app nrf52840dk_nrf52840 (read/write) 868523 871699 3176 0.4
text 585080 588164 3084 0.5
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 864943 3180 0.4
text 580312 583396 3084 0.5
p6 all-clusters-app default (read/write) 2340160 2349464 9304 0.4
.bss 106596 107596 1000 0.9
.text 1298424 1307728 9304 0.7
light-app default .text 1237944 1242352 4408 0.4
lock-app default .text 1214248 1218904 4656 0.4
qpg lighting-app qpg6100+debug (read only) 510464 513724 3260 0.6
.text 505144 508404 3260 0.6
lock-app qpg6100+debug (read only) 484132 487464 3332 0.7
.text 478812 482144 3332 0.7
telink lighting-app tlsr9518adk80d (read/write) 794746 798390 3644 0.5
text 554540 558094 3554 0.6
Increases (33 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 186c004 3bfb57b change % change
efr32 lighting-app BRD4161A (read only) 751672 758896 7224 1.0
.text 751664 758888 7224 1.0
BRD4161A+rpc (read only) 780344 787560 7216 0.9
.text 780336 787552 7216 0.9
lock-app BRD4161A (read only) 726496 733952 7456 1.0
.text 726488 733944 7456 1.0
window-app BRD4161A (read only) 729000 736224 7224 1.0
.text 728992 736216 7224 1.0
esp32 all-clusters-app c3devkit (read only) 847922 852542 4620 0.5
(read/write) 1222786 1290914 68128 5.6
.dram0.bss 55352 56352 1000 1.8
.flash.rodata 167920 169520 1600 1.0
.flash.text 847922 852542 4620 0.5
m5stack (read only) 918319 922407 4088 0.4
(read/write) 421756 424356 2600 0.6
.dram0.bss 60736 61736 1000 1.6
.flash.rodata 195724 197324 1600 0.8
.flash.text 912935 917023 4088 0.4
k32w lighting-app k32w061+se05x+release (read/write) 728696 731924 3228 0.4
.text 641724 644952 3228 0.5
lock-app k32w061+debug (read/write) 618736 622092 3356 0.5
.text 541132 544488 3356 0.6
shell k32w061+debug (read/write) 684644 687984 3340 0.5
.text 595420 598760 3340 0.6
linux all-clusters-app debug (read only) 1851521 1872937 21416 1.2
(read/write) 123344 124336 992 0.8
.bss 49680 50672 992 2.0
.rodata 151285 152117 832 0.5
.text 1557154 1577714 20560 1.3
bridge-app debug+rpc (read only) 1432645 1444405 11760 0.8
.text 1205797 1218005 12208 1.0
chip-tool debug (read only) 6619645 6628293 8648 0.1
(read/write) 199688 199752 64 0.0
.data.rel.ro 158456 158520 64 0.0
.rodata 309912 310776 864 0.3
.text 5905173 5912789 7616 0.1
lighting-app debug+rpc (read only) 1717761 1729553 11792 0.7
.text 1432514 1444722 12208 0.9
ota-provider-app debug (read only) 1393289 1401065 7776 0.6
.rodata 122792 122856 64 0.1
.text 1165810 1173522 7712 0.7
ota-requestor-app debug (read only) 1502561 1510321 7760 0.5
.rodata 135504 135600 96 0.1
.text 1258418 1266082 7664 0.6
shell debug (read only) 823129 823449 320 0.0
.rodata 84338 84658 320 0.4
tv-app debug (read only) 2031625 2046585 14960 0.7
.text 1701538 1717490 15952 0.9
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2307096 2313152 6056 0.3
.bss 178404 179404 1000 0.6
.text 1269672 1275728 6056 0.5
lighting-app CY8CPROTO_062_4343W+release (read/write) 2296296 2299096 2800 0.1
.text 1258896 1261696 2800 0.2
lock-app CY8CPROTO_062_4343W+release (read/write) 2270288 2273088 2800 0.1
.text 1232888 1235688 2800 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 894895 3180 0.4
rodata 99588 99680 92 0.1
text 602824 605904 3080 0.5
nrf52840dk_nrf52840+rpc (read/write) 855091 858255 3164 0.4
rodata 90948 91040 92 0.1
text 577820 580900 3080 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 817610 820790 3180 0.4
rodata 94844 94936 92 0.1
text 533156 536240 3084 0.6
lock-app nrf52840dk_nrf52840 (read/write) 863639 866915 3276 0.4
rodata 95704 95796 92 0.1
text 581540 584716 3176 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 789794 793050 3256 0.4
rodata 90996 91084 88 0.1
text 511964 515140 3176 0.6
pump-app nrf52840dk_nrf52840 (read/write) 868523 871699 3176 0.4
rodata 97060 97148 88 0.1
text 585080 588164 3084 0.5
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 864943 3180 0.4
rodata 95196 95288 92 0.1
text 580312 583396 3084 0.5
p6 all-clusters-app default (read/write) 2340160 2349464 9304 0.4
.bss 106596 107596 1000 0.9
.text 1298424 1307728 9304 0.7
light-app default (read/write) 2279680 2284088 4408 0.2
.text 1237944 1242352 4408 0.4
lock-app default (read/write) 2255984 2260640 4656 0.2
.text 1214248 1218904 4656 0.4
qpg lighting-app qpg6100+debug (read only) 510464 513724 3260 0.6
.text 505144 508404 3260 0.6
lock-app qpg6100+debug (read only) 484132 487464 3332 0.7
.text 478812 482144 3332 0.7
telink lighting-app tlsr9518adk80d (read/write) 794746 798390 3644 0.5
text 554540 558094 3554 0.6
Decreases (5 builds for linux, mbed, p6)
platform target config section 186c004 3bfb57b change % change
linux bridge-app debug+rpc .rodata 121948 121500 -448 -0.4
lighting-app debug+rpc .rodata 142577 142161 -416 -0.3
tv-app debug .rodata 175344 174352 -992 -0.6
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 852856 851856 -1000 -0.1
p6 all-clusters-app default .heap 924280 923280 -1000 -0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 186c004 3bfb57b change % change
efr32 lighting-app BRD4161A (read only) 751672 758896 7224 1.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751664 758888 7224 1.0
BRD4161A+rpc (read only) 780344 787560 7216 0.9
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780336 787552 7216 0.9
lock-app BRD4161A (read only) 726496 733952 7456 1.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 726488 733944 7456 1.0
window-app BRD4161A (read only) 729000 736224 7224 1.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 728992 736216 7224 1.0
esp32 all-clusters-app c3devkit (read only) 847922 852542 4620 0.5
(read/write) 1222786 1290914 68128 5.6
.dram0.bss 55352 56352 1000 1.8
.dram0.data 14052 14052 0 0.0
.flash.rodata 167920 169520 1600 1.0
.flash.text 847922 852542 4620 0.5
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918319 922407 4088 0.4
(read/write) 421756 424356 2600 0.6
.dram0.bss 60736 61736 1000 1.6
.dram0.data 34016 34016 0 0.0
.flash.rodata 195724 197324 1600 0.8
.flash.text 912935 917023 4088 0.4
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 731924 3228 0.4
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641724 644952 3228 0.5
lock-app k32w061+debug (read/write) 618736 622092 3356 0.5
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 541132 544488 3356 0.6
shell k32w061+debug (read/write) 684644 687984 3340 0.5
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 595420 598760 3340 0.6
linux all-clusters-app debug (read only) 1851521 1872937 21416 1.2
(read/write) 123344 124336 992 0.8
.bss 49680 50672 992 2.0
.data 1120 1120 0 0.0
.data.rel.ro 67104 67104 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 151285 152117 832 0.5
.text 1557154 1577714 20560 1.3
bridge-app debug+rpc (read only) 1432645 1444405 11760 0.8
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121948 121500 -448 -0.4
.text 1205797 1218005 12208 1.0
chip-tool debug (read only) 6619645 6628293 8648 0.1
(read/write) 199688 199752 64 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158456 158520 64 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 309912 310776 864 0.3
.text 5905173 5912789 7616 0.1
lighting-app debug+rpc (read only) 1717761 1729553 11792 0.7
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142577 142161 -416 -0.3
.text 1432514 1444722 12208 0.9
ota-provider-app debug (read only) 1393289 1401065 7776 0.6
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122792 122856 64 0.1
.text 1165810 1173522 7712 0.7
ota-requestor-app debug (read only) 1502561 1510321 7760 0.5
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135504 135600 96 0.1
.text 1258418 1266082 7664 0.6
shell debug (read only) 823129 823449 320 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84338 84658 320 0.4
.text 631954 631954 0 0.0
tv-app debug (read only) 2031625 2046585 14960 0.7
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 175344 174352 -992 -0.6
.text 1701538 1717490 15952 0.9
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307096 2313152 6056 0.3
.bss 178404 179404 1000 0.6
.data 5184 5184 0 0.0
.heap 852856 851856 -1000 -0.1
.text 1269672 1275728 6056 0.5
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296296 2299096 2800 0.1
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1258896 1261696 2800 0.2
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270288 2273088 2800 0.1
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1232888 1235688 2800 0.2
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 894895 3180 0.4
bss 113756 113756 0 0.0
rodata 99588 99680 92 0.1
text 602824 605904 3080 0.5
nrf52840dk_nrf52840+rpc (read/write) 855091 858255 3164 0.4
bss 110104 110104 0 0.0
rodata 90948 91040 92 0.1
text 577820 580900 3080 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 817610 820790 3180 0.4
bss 115128 115128 0 0.0
rodata 94844 94936 92 0.1
text 533156 536240 3084 0.6
lock-app nrf52840dk_nrf52840 (read/write) 863639 866915 3276 0.4
bss 111016 111016 0 0.0
rodata 95704 95796 92 0.1
text 581540 584716 3176 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 789794 793050 3256 0.4
bss 112428 112428 0 0.0
rodata 90996 91084 88 0.1
text 511964 515140 3176 0.6
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868523 871699 3176 0.4
bss 110928 110928 0 0.0
rodata 97060 97148 88 0.1
text 585080 588164 3084 0.5
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 864943 3180 0.4
bss 110808 110808 0 0.0
rodata 95196 95288 92 0.1
text 580312 583396 3084 0.5
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2340160 2349464 9304 0.4
.bss 106596 107596 1000 0.9
.data 2464 2464 0 0.0
.heap 924280 923280 -1000 -0.1
.text 1298424 1307728 9304 0.7
light-app default (read/write) 2279680 2284088 4408 0.2
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1237944 1242352 4408 0.4
lock-app default (read/write) 2255984 2260640 4656 0.2
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1214248 1218904 4656 0.4
qpg lighting-app qpg6100+debug (read only) 510464 513724 3260 0.6
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505144 508404 3260 0.6
lock-app qpg6100+debug (read only) 484132 487464 3332 0.7
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 478812 482144 3332 0.7
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794746 798390 3644 0.5
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554540 558094 3554 0.6

@erjiaqing erjiaqing marked this pull request as ready for review December 6, 2021 06:33
@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12019: Size comparison from 186c004 to 50b6a73

Increases above 0.2%:

platform target config section 186c004 50b6a73 change % change
efr32 lighting-app BRD4161A (read only) 751672 758896 7224 1.0
.text 751664 758888 7224 1.0
BRD4161A+rpc (read only) 780344 787544 7200 0.9
.text 780336 787536 7200 0.9
lock-app BRD4161A (read only) 726496 733952 7456 1.0
.text 726488 733944 7456 1.0
window-app BRD4161A (read only) 729000 736224 7224 1.0
.text 728992 736216 7224 1.0
esp32 all-clusters-app c3devkit (read only) 847922 852538 4616 0.5
(read/write) 1222786 1290914 68128 5.6
.dram0.bss 55352 56352 1000 1.8
.flash.rodata 167920 169520 1600 1.0
.flash.text 847922 852538 4616 0.5
m5stack (read only) 918319 922399 4080 0.4
(read/write) 421756 424356 2600 0.6
.dram0.bss 60736 61736 1000 1.6
.flash.rodata 195724 197324 1600 0.8
.flash.text 912935 917015 4080 0.4
k32w lighting-app k32w061+se05x+release (read/write) 728696 731908 3212 0.4
.text 641724 644936 3212 0.5
lock-app k32w061+debug (read/write) 618736 622076 3340 0.5
.text 541132 544472 3340 0.6
shell k32w061+debug (read/write) 684644 687968 3324 0.5
.text 595420 598744 3324 0.6
linux all-clusters-app debug (read only) 1851521 1872825 21304 1.2
(read/write) 123344 124336 992 0.8
.bss 49680 50672 992 2.0
.rodata 151285 152117 832 0.5
.text 1557154 1577602 20448 1.3
bridge-app debug+rpc (read only) 1432645 1444277 11632 0.8
.text 1205797 1217877 12080 1.0
chip-tool debug .rodata 309912 310776 864 0.3
lighting-app debug+rpc (read only) 1717761 1729441 11680 0.7
.text 1432514 1444610 12096 0.8
ota-provider-app debug (read only) 1393289 1400953 7664 0.6
.text 1165810 1173410 7600 0.7
ota-requestor-app debug (read only) 1502561 1510209 7648 0.5
.text 1258418 1265970 7552 0.6
shell debug .rodata 84338 84658 320 0.4
tv-app debug (read only) 2031625 2046473 14848 0.7
.text 1701538 1717378 15840 0.9
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2307096 2313152 6056 0.3
.bss 178404 179404 1000 0.6
.text 1269672 1275728 6056 0.5
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 894879 3164 0.4
text 602824 605896 3072 0.5
nrf52840dk_nrf52840+rpc (read/write) 855091 858255 3164 0.4
text 577820 580892 3072 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 817610 820790 3180 0.4
text 533156 536232 3076 0.6
lock-app nrf52840dk_nrf52840 (read/write) 863639 866899 3260 0.4
text 581540 584708 3168 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 789794 793050 3256 0.4
text 511964 515132 3168 0.6
pump-app nrf52840dk_nrf52840 (read/write) 868523 871683 3160 0.4
text 585080 588156 3076 0.5
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 864927 3164 0.4
text 580312 583388 3076 0.5
p6 all-clusters-app default (read/write) 2340160 2349448 9288 0.4
.bss 106596 107596 1000 0.9
.text 1298424 1307712 9288 0.7
light-app default .text 1237944 1242336 4392 0.4
lock-app default .text 1214248 1218888 4640 0.4
qpg lighting-app qpg6100+debug (read only) 510464 513724 3260 0.6
.text 505144 508404 3260 0.6
lock-app qpg6100+debug (read only) 484132 487464 3332 0.7
.text 478812 482144 3332 0.7
telink lighting-app tlsr9518adk80d (read/write) 794746 798382 3636 0.5
text 554540 558088 3548 0.6
Increases (33 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 186c004 50b6a73 change % change
efr32 lighting-app BRD4161A (read only) 751672 758896 7224 1.0
.text 751664 758888 7224 1.0
BRD4161A+rpc (read only) 780344 787544 7200 0.9
.text 780336 787536 7200 0.9
lock-app BRD4161A (read only) 726496 733952 7456 1.0
.text 726488 733944 7456 1.0
window-app BRD4161A (read only) 729000 736224 7224 1.0
.text 728992 736216 7224 1.0
esp32 all-clusters-app c3devkit (read only) 847922 852538 4616 0.5
(read/write) 1222786 1290914 68128 5.6
.dram0.bss 55352 56352 1000 1.8
.flash.rodata 167920 169520 1600 1.0
.flash.text 847922 852538 4616 0.5
m5stack (read only) 918319 922399 4080 0.4
(read/write) 421756 424356 2600 0.6
.dram0.bss 60736 61736 1000 1.6
.flash.rodata 195724 197324 1600 0.8
.flash.text 912935 917015 4080 0.4
k32w lighting-app k32w061+se05x+release (read/write) 728696 731908 3212 0.4
.text 641724 644936 3212 0.5
lock-app k32w061+debug (read/write) 618736 622076 3340 0.5
.text 541132 544472 3340 0.6
shell k32w061+debug (read/write) 684644 687968 3324 0.5
.text 595420 598744 3324 0.6
linux all-clusters-app debug (read only) 1851521 1872825 21304 1.2
(read/write) 123344 124336 992 0.8
.bss 49680 50672 992 2.0
.rodata 151285 152117 832 0.5
.text 1557154 1577602 20448 1.3
bridge-app debug+rpc (read only) 1432645 1444277 11632 0.8
.text 1205797 1217877 12080 1.0
chip-tool debug (read only) 6619645 6628165 8520 0.1
(read/write) 199688 199752 64 0.0
.data.rel.ro 158456 158520 64 0.0
.rodata 309912 310776 864 0.3
.text 5905173 5912661 7488 0.1
lighting-app debug+rpc (read only) 1717761 1729441 11680 0.7
.text 1432514 1444610 12096 0.8
ota-provider-app debug (read only) 1393289 1400953 7664 0.6
.rodata 122792 122856 64 0.1
.text 1165810 1173410 7600 0.7
ota-requestor-app debug (read only) 1502561 1510209 7648 0.5
.rodata 135504 135600 96 0.1
.text 1258418 1265970 7552 0.6
shell debug (read only) 823129 823449 320 0.0
.rodata 84338 84658 320 0.4
tv-app debug (read only) 2031625 2046473 14848 0.7
.text 1701538 1717378 15840 0.9
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2307096 2313152 6056 0.3
.bss 178404 179404 1000 0.6
.text 1269672 1275728 6056 0.5
lighting-app CY8CPROTO_062_4343W+release (read/write) 2296296 2299096 2800 0.1
.text 1258896 1261696 2800 0.2
lock-app CY8CPROTO_062_4343W+release (read/write) 2270288 2273088 2800 0.1
.text 1232888 1235688 2800 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 894879 3164 0.4
rodata 99588 99680 92 0.1
text 602824 605896 3072 0.5
nrf52840dk_nrf52840+rpc (read/write) 855091 858255 3164 0.4
rodata 90948 91040 92 0.1
text 577820 580892 3072 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 817610 820790 3180 0.4
rodata 94844 94936 92 0.1
text 533156 536232 3076 0.6
lock-app nrf52840dk_nrf52840 (read/write) 863639 866899 3260 0.4
rodata 95704 95796 92 0.1
text 581540 584708 3168 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 789794 793050 3256 0.4
rodata 90996 91084 88 0.1
text 511964 515132 3168 0.6
pump-app nrf52840dk_nrf52840 (read/write) 868523 871683 3160 0.4
rodata 97060 97148 88 0.1
text 585080 588156 3076 0.5
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 864927 3164 0.4
rodata 95196 95288 92 0.1
text 580312 583388 3076 0.5
p6 all-clusters-app default (read/write) 2340160 2349448 9288 0.4
.bss 106596 107596 1000 0.9
.text 1298424 1307712 9288 0.7
light-app default (read/write) 2279680 2284072 4392 0.2
.text 1237944 1242336 4392 0.4
lock-app default (read/write) 2255984 2260624 4640 0.2
.text 1214248 1218888 4640 0.4
qpg lighting-app qpg6100+debug (read only) 510464 513724 3260 0.6
.text 505144 508404 3260 0.6
lock-app qpg6100+debug (read only) 484132 487464 3332 0.7
.text 478812 482144 3332 0.7
telink lighting-app tlsr9518adk80d (read/write) 794746 798382 3636 0.5
text 554540 558088 3548 0.6
Decreases (5 builds for linux, mbed, p6)
platform target config section 186c004 50b6a73 change % change
linux bridge-app debug+rpc .rodata 121948 121500 -448 -0.4
lighting-app debug+rpc .rodata 142577 142161 -416 -0.3
tv-app debug .rodata 175344 174352 -992 -0.6
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 852856 851856 -1000 -0.1
p6 all-clusters-app default .heap 924280 923280 -1000 -0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 186c004 50b6a73 change % change
efr32 lighting-app BRD4161A (read only) 751672 758896 7224 1.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751664 758888 7224 1.0
BRD4161A+rpc (read only) 780344 787544 7200 0.9
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780336 787536 7200 0.9
lock-app BRD4161A (read only) 726496 733952 7456 1.0
(read/write) 117968 117968 0 0.0
.bss 116176 116176 0 0.0
.data 1788 1788 0 0.0
.text 726488 733944 7456 1.0
window-app BRD4161A (read only) 729000 736224 7224 1.0
(read/write) 118168 118168 0 0.0
.bss 116376 116376 0 0.0
.data 1792 1792 0 0.0
.text 728992 736216 7224 1.0
esp32 all-clusters-app c3devkit (read only) 847922 852538 4616 0.5
(read/write) 1222786 1290914 68128 5.6
.dram0.bss 55352 56352 1000 1.8
.dram0.data 14052 14052 0 0.0
.flash.rodata 167920 169520 1600 1.0
.flash.text 847922 852538 4616 0.5
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918319 922399 4080 0.4
(read/write) 421756 424356 2600 0.6
.dram0.bss 60736 61736 1000 1.6
.dram0.data 34016 34016 0 0.0
.flash.rodata 195724 197324 1600 0.8
.flash.text 912935 917015 4080 0.4
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728696 731908 3212 0.4
.bss 79312 79312 0 0.0
.data 1860 1860 0 0.0
.text 641724 644936 3212 0.5
lock-app k32w061+debug (read/write) 618736 622076 3340 0.5
.bss 69976 69976 0 0.0
.data 1828 1828 0 0.0
.text 541132 544472 3340 0.6
shell k32w061+debug (read/write) 684644 687968 3324 0.5
.bss 81624 81624 0 0.0
.data 1800 1800 0 0.0
.text 595420 598744 3324 0.6
linux all-clusters-app debug (read only) 1851521 1872825 21304 1.2
(read/write) 123344 124336 992 0.8
.bss 49680 50672 992 2.0
.data 1120 1120 0 0.0
.data.rel.ro 67104 67104 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 151285 152117 832 0.5
.text 1557154 1577602 20448 1.3
bridge-app debug+rpc (read only) 1432645 1444277 11632 0.8
(read/write) 74648 74648 0 0.0
.bss 36272 36272 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31560 31560 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121948 121500 -448 -0.4
.text 1205797 1217877 12080 1.0
chip-tool debug (read only) 6619645 6628165 8520 0.1
(read/write) 199688 199752 64 0.0
.bss 34536 34536 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158456 158520 64 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 309912 310776 864 0.3
.text 5905173 5912661 7488 0.1
lighting-app debug+rpc (read only) 1717761 1729441 11680 0.7
(read/write) 107680 107680 0 0.0
.bss 41968 41968 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59056 59056 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142577 142161 -416 -0.3
.text 1432514 1444610 12096 0.8
ota-provider-app debug (read only) 1393289 1400953 7664 0.6
(read/write) 72848 72848 0 0.0
.bss 38848 38848 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 122792 122856 64 0.1
.text 1165810 1173410 7600 0.7
ota-requestor-app debug (read only) 1502561 1510209 7648 0.5
(read/write) 77896 77896 0 0.0
.bss 42016 42016 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29656 29656 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 135504 135600 96 0.1
.text 1258418 1265970 7552 0.6
shell debug (read only) 823129 823449 320 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84338 84658 320 0.4
.text 631954 631954 0 0.0
tv-app debug (read only) 2031625 2046473 14848 0.7
(read/write) 320032 320032 0 0.0
.bss 247288 247288 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64168 64168 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 175344 174352 -992 -0.6
.text 1701538 1717378 15840 0.9
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307096 2313152 6056 0.3
.bss 178404 179404 1000 0.6
.data 5184 5184 0 0.0
.heap 852856 851856 -1000 -0.1
.text 1269672 1275728 6056 0.5
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296296 2299096 2800 0.1
.bss 173304 173304 0 0.0
.data 5496 5496 0 0.0
.heap 857648 857648 0 0.0
.text 1258896 1261696 2800 0.2
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270288 2273088 2800 0.1
.bss 172344 172344 0 0.0
.data 5496 5496 0 0.0
.heap 858608 858608 0 0.0
.text 1232888 1235688 2800 0.2
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891715 894879 3164 0.4
bss 113756 113756 0 0.0
rodata 99588 99680 92 0.1
text 602824 605896 3072 0.5
nrf52840dk_nrf52840+rpc (read/write) 855091 858255 3164 0.4
bss 110104 110104 0 0.0
rodata 90948 91040 92 0.1
text 577820 580892 3072 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 817610 820790 3180 0.4
bss 115128 115128 0 0.0
rodata 94844 94936 92 0.1
text 533156 536232 3076 0.6
lock-app nrf52840dk_nrf52840 (read/write) 863639 866899 3260 0.4
bss 111016 111016 0 0.0
rodata 95704 95796 92 0.1
text 581540 584708 3168 0.5
nrf5340dk_nrf5340_cpuapp (read/write) 789794 793050 3256 0.4
bss 112428 112428 0 0.0
rodata 90996 91084 88 0.1
text 511964 515132 3168 0.6
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868523 871683 3160 0.4
bss 110928 110928 0 0.0
rodata 97060 97148 88 0.1
text 585080 588156 3076 0.5
pump-controller-app nrf52840dk_nrf52840 (read/write) 861763 864927 3164 0.4
bss 110808 110808 0 0.0
rodata 95196 95288 92 0.1
text 580312 583388 3076 0.5
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2340160 2349448 9288 0.4
.bss 106596 107596 1000 0.9
.data 2464 2464 0 0.0
.heap 924280 923280 -1000 -0.1
.text 1298424 1307712 9288 0.7
light-app default (read/write) 2279680 2284072 4392 0.2
.bss 98536 98536 0 0.0
.data 2336 2336 0 0.0
.heap 932472 932472 0 0.0
.text 1237944 1242336 4392 0.4
lock-app default (read/write) 2255984 2260624 4640 0.2
.bss 97416 97416 0 0.0
.data 2296 2296 0 0.0
.heap 933632 933632 0 0.0
.text 1214248 1218888 4640 0.4
qpg lighting-app qpg6100+debug (read only) 510464 513724 3260 0.6
(read/write) 122332 122332 0 0.0
.bss 80272 80272 0 0.0
.data 964 964 0 0.0
.text 505144 508404 3260 0.6
lock-app qpg6100+debug (read only) 484132 487464 3332 0.7
(read/write) 122336 122336 0 0.0
.bss 79408 79408 0 0.0
.data 920 920 0 0.0
.text 478812 482144 3332 0.7
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794746 798382 3636 0.5
bss 80332 80332 0 0.0
noinit 37160 37160 0 0.0
text 554540 558088 3548 0.6

@yunhanw-google yunhanw-google merged commit bfdbd45 into project-chip:master Dec 6, 2021
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Dec 7, 2021
@bzbarsky-apple
Some interface cleanup on AttributeValueEncoder.
b72d3f5 
1) Address unaddressed or deferred review comments from project-chip#12019.
2) Add a simpler way to encode a null value.
@bzbarsky-apple bzbarsky-apple mentioned this pull request Dec 7, 2021
Merged
andy31415 pushed a commit that referenced this pull request Dec 7, 2021
@bzbarsky-apple
Some interface cleanup on AttributeValueEncoder. (#12661)
c71b466 
1) Address unaddressed or deferred review comments from #12019.
2) Add a simpler way to encode a null value.
@nicelyjust nicelyjust mentioned this pull request May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
app examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erjiaqing @woody-apple @bzbarsky-apple @msandstedt @yunhanw-google