-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow commissionee device read fabric list in Android #18664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
reviewed
May 20, 2022
PR #18664: Size comparison from d346617 to b0046f2 Full report (32 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
May 24, 2022
bzbarsky-apple
approved these changes
May 25, 2022
lazarkov
approved these changes
May 25, 2022
PR #18664: Size comparison from a3fdd05 to 2a4e4ff Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
chrisdecenzo
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On some devices with a screen(such as TV), User want to know which commissioners currently have and how many,but now we dont support it.
Change overview
allows the commissionee to see what the current commissioners are,so add two JNI function,one reads fabric count,the other reads fabric list.
Testing
run ./scripts/examples/gn_build_example.sh examples/chip-tool
run ./scripts/examples/gn_android_example.sh examples/tv-app/android out/android-arm64-chip-tvserver
chip-tool pairing