-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark attributes that we always intercept as external #11070
Mark attributes that we always intercept as external #11070
Conversation
PR #11070: Size comparison from f1b8e2c to d20601a Increases (5 builds for linux, mbed, p6)
Decreases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
@yufengwangca - conflict resolution needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description talks about "software diagnostics", but there are no changes to that cluster. That's just because it does not have any never-intercepted attributes, right?
PR #11070: Size comparison from 551ba65 to 9b21302 Increases (6 builds for esp32, linux, mbed, p6)
Decreases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #11070: Size comparison from 149e582 to 4792292 Increases (5 builds for linux, mbed, p6)
Decreases (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (27 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
PR #11070: Size comparison from e7c1d2b to c60ec07 Increases (5 builds for esp32, mbed, p6)
Decreases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #11070: Size comparison from 2c1dceb to 4e8869d Increases (20 builds for esp32, linux, mbed, nrfconnect, p6, telink)
Decreases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
What is being fixed? Examples:
Change overview
Mark attributes that we always intercept as external.
Please note, I only cover the general diagnostic, and operational credentials clusters I recently modified in this PR.
Testing
How was this tested? (at least one bullet point required)