[thread] add Thread stack lock held for output the unicast addresses (#…

…33661) * [thread] add Thread stack lock held for output the unicast addresses * [thread] add Thread stack lock held for output the unicast addresses
project-chip · Aug 13, 2024 · 1301081 · 1301081
1 parent 0e2a02a
commit 1301081
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp b/src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp
@@ -247,7 +247,9 @@ void GenericThreadStackManagerImpl_OpenThread<ImplClass>::_OnPlatformEvent(const
         }
 
 #if CHIP_DETAIL_LOGGING
+        Impl()->LockThreadStack();
         LogOpenThreadStateChange(mOTInst, event->ThreadStateChange.OpenThread.Flags);
+        Impl()->UnlockThreadStack();
 #endif // CHIP_DETAIL_LOGGING
     }
 }

diff --git a/src/platform/OpenThread/OpenThreadUtils.cpp b/src/platform/OpenThread/OpenThreadUtils.cpp
@@ -87,11 +87,6 @@ void RegisterOpenThreadErrorFormatter(void)
     RegisterErrorFormatter(&sOpenThreadErrorFormatter);
 }
 
-/**
- * Log information related to a state change in the OpenThread stack.
- *
- * NB: This function *must* be called with the Thread stack lock held.
- */
 void LogOpenThreadStateChange(otInstance * otInst, uint32_t flags)
 {
 #if CHIP_DETAIL_LOGGING

diff --git a/src/platform/OpenThread/OpenThreadUtils.h b/src/platform/OpenThread/OpenThreadUtils.h
@@ -60,6 +60,12 @@ namespace Internal {
 
 extern CHIP_ERROR MapOpenThreadError(otError otErr);
 extern void RegisterOpenThreadErrorFormatter(void);
+
+/**
+ * Log information related to a state change in the OpenThread stack.
+ *
+ * NB: This function *must* be called with the Thread stack lock held.
+ */
 extern void LogOpenThreadStateChange(otInstance * otInst, uint32_t flags);
 extern void LogOpenThreadPacket(const char * titleStr, otMessage * pkt);
 extern bool IsOpenThreadMeshLocalAddress(otInstance * otInst, const Inet::IPAddress & addr);