Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update obsolete Brave info (pkg on macOS) #2647

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

fmarier
Copy link
Contributor

@fmarier fmarier commented Jul 17, 2024

Changes proposed in this PR:

Conflict of interest statement: I work for Brave Software.

  • I agree to the terms listed below:
    Contribution terms (click to expand) 1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.

@fmarier fmarier force-pushed the remove-obsolete-brave-info branch from 3e89108 to 5352124 Compare July 17, 2024 19:49
Copy link

github-actions bot commented Jul 17, 2024

Your preview is ready!

Name Link
🔨 Latest commit 67cdae5
😎 Preview https://2647--glowing-salamander-8d7127.netlify.app/

@fmarier fmarier force-pushed the remove-obsolete-brave-info branch from 5352124 to 7ffa65d Compare July 17, 2024 20:09
@dngray
Copy link
Member

dngray commented Jul 19, 2024

I'm curious to know what version of Brave you have, because this option still seems to be in the Linux version #2641 (review)

@dngray dngray added the t:correction content corrections or errors label Jul 19, 2024
@fmarier
Copy link
Contributor Author

fmarier commented Jul 19, 2024

I'm curious to know what version of Brave you have, because this option still seems to be in the Linux version #2641 (review)

Latest version in the official .deb repo:

Brave	1.67.123 Chromium: 126.0.6478.126 (Official build) (64 bits) 
Revision	fc7619ef621fe4e6a0fa8b16c718f78ffc97a861
OS	Linux

@fmarier fmarier force-pushed the remove-obsolete-brave-info branch from 7ffa65d to b8afa3c Compare July 19, 2024 18:01
@fmarier
Copy link
Contributor Author

fmarier commented Jul 19, 2024

I'll rebase this once #2641 lands to remove the fingerprinting commit.

Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Dang, glad they made this change to macOS downloads.

@dngray
Copy link
Member

dngray commented Jul 20, 2024

Latest version in the official .deb repo:

That's interesting because I was using the latest one from the fedora repo in the release channel. Version 1.67.134 Chromium: 126.0.6478.186 (Official Build) (64-bit). I installed beta 1.69.117-1, now shows Version 1.69.117 Chromium: 127.0.6533.57 (Official Build) beta (64-bit) and it still has that option as strict.

I guess as your comment there #2641 (comment) this will probably change soon.

Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wouldn't mind rebasing then I'll approve :)

The `.pkg` binary was replaced by a regular `.dmg` in 1.60: brave/brave-browser#32316
@fmarier fmarier force-pushed the remove-obsolete-brave-info branch from b8afa3c to 67cdae5 Compare July 20, 2024 21:45
@fmarier fmarier changed the title Update obsolete Brave info (strict fingerprinting and pkg on macOS) Update obsolete Brave info (pkg on macOS) Jul 20, 2024
@fmarier
Copy link
Contributor Author

fmarier commented Jul 20, 2024

@jonaharagon Rebased.

Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@fmarier
Copy link
Contributor Author

fmarier commented Jul 20, 2024

That's interesting because I was using the latest one from the fedora repo in the release channel. Version 1.67.134 Chromium: 126.0.6478.186 (Official Build) (64-bit). I installed beta 1.69.117-1, now shows Version 1.69.117 Chromium: 127.0.6533.57 (Official Build) beta (64-bit) and it still has that option as strict.

Even after you restart the browser? If so, are you blocking https://variations.brave.com/ by any chance? That's where the flag settings file (called a seed) is downloaded from. If that doesn't get downloaded for you, then you're not getting the intended configuration. You may be behind on some features we're only enabling via that mechanism.

@jonaharagon jonaharagon merged commit 67cdae5 into privacyguides:main Jul 21, 2024
11 checks passed
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/2024-07-21/19599/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:correction content corrections or errors
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants