-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update obsolete Brave info (pkg on macOS) #2647
Update obsolete Brave info (pkg on macOS) #2647
Conversation
3e89108
to
5352124
Compare
✅ Your preview is ready!
|
5352124
to
7ffa65d
Compare
I'm curious to know what version of Brave you have, because this option still seems to be in the Linux version #2641 (review) |
Latest version in the official .deb repo:
|
7ffa65d
to
b8afa3c
Compare
I'll rebase this once #2641 lands to remove the fingerprinting commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Dang, glad they made this change to macOS downloads.
That's interesting because I was using the latest one from the fedora repo in the release channel. Version 1.67.134 Chromium: 126.0.6478.186 (Official Build) (64-bit). I installed beta 1.69.117-1, now shows Version 1.69.117 Chromium: 127.0.6533.57 (Official Build) beta (64-bit) and it still has that option as strict. I guess as your comment there #2641 (comment) this will probably change soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you wouldn't mind rebasing then I'll approve :)
The `.pkg` binary was replaced by a regular `.dmg` in 1.60: brave/brave-browser#32316
b8afa3c
to
67cdae5
Compare
@jonaharagon Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you!
Even after you restart the browser? If so, are you blocking https://variations.brave.com/ by any chance? That's where the flag settings file (called a |
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
Changes proposed in this PR:
Remove anti-fingerprinting mode which no longer existsConflict of interest statement: I work for Brave Software.
Contribution terms (click to expand)
1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.