Brave MacOS downloads should not use .pkg #32316

pes10k · 2023-08-16T22:56:27Z

Currently, downloading the MacOS build from brave.com gives a .pkg (macOS installer) binary with the refcode in the file and product name

This is bad for a bunch of reasons, inc

the installer looks extremely fishy. Other browsers don’t need this
its not core, but it results in very fishy looking UI (I expect we could fix this w/in the installer approach, but its another thing to fix). See screenshot below
I expect the installer is causing compat and other very-visible issues (https://bravesoftware.slack.com/archives/C7VLGSR55/p1691093591839749 / Can't reset "corrupt" settings #32074). These might also be fixable w/in the installer approach, but its another footgun
it makes the fact that we ship a referrer code very obvious to users (its in the UI and download name) when it doesn’t need to be. - This is an optics concern, not a root-privacy one, but we should avoid unforced-optics problems where possible
it makes it more difficult for us to give advice to users on what downloads to trust, when the true brave downloads look “funny”

We should instead offer the binary as a standard .dmg, unprivileged app. We can solve the refcode problem by creating a different binary/.dmg for each refcode as needed

rebron · 2023-09-01T17:08:02Z

DevOps issue: https://github.com/brave/devops/issues/10373

bsclifton · 2023-09-15T07:17:24Z

The solution identified is that we'll have some new extended attributes on the .app file:

com.brave.refcode has the referral code (ex: BRV002)
com.brave.privacypolicy should be added with the value https://brave.com/s/refcodes

The code in brave-core should be adjusted to read this value (if present) and initialize the Referral Service with this value.
https://github.com/brave/brave-core/blob/db5c6571fd2c4036ed47a0a7f95b46a1a0517edb/components/brave_referrals/browser/brave_referrals_service.cc#L265-L268

Currently, the code looks for a file promoCode in the profile folder. We can still keep that check - but if the xattr com.brave.refcode is found, it should have higher precedence.

bridiver · 2023-09-21T19:01:37Z

similar upstream code

bool GetFileExtendedAttribute(const base::FilePath& path,
                              const char* name,
                              std::vector<char>* value) {
  ssize_t len = getxattr(path.value().c_str(), name, nullptr, 0);
  if (len < 0) {
    PLOG_IF(ERROR, errno != ENODATA) << "getxattr: " << path;
    return false;
  }
  value->resize(len);
  if (getxattr(path.value().c_str(), name, value->data(), len) != len) {
    PLOG(ERROR) << "getxattr: " << path;
    return false;
  }
  return true;
}

so looks like using #include <sys/xattr.h> is ok, but that definitely needs to run on a task runner and no UI thread

LaurenWags · 2023-10-06T19:35:09Z

@brave/qa-team labeling as QA/Blocked until we have clarification on test plan for this one. Waiting on more information regarding specific .dmg files and list of new promo codes. Also need to check backwards compatibility with .pkg files.

kjozwiak · 2023-11-01T04:55:30Z

`macOS 14.0 Sonoma x64`

`BRV001 Referral Code`

Using Brave-Browser-BRV001-x64.dmg - PASSED

Verification PASSED on macOS 14.0 Sonoma x64 using the following build(s):

Brave | 1.60.110 Chromium: 119.0.6045.105 (Official Build) (x86_64)
--- | ---
Revision | 0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS | macOS Version 14.0 (Build 23A344)

Quick note: The above requires specific executables which can be downloaded via https://bravesoftware.slack.com/archives/C05FK45FN0M/p1698866128534639?thread_ts=1697728273.865229&cid=C05FK45FN0M.

downloaded Brave-Browser-BRV001-x64.dmg and ensured Brave installed without any issues/failures/crashes
launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV001”}; as per the following:

“promo_code”: {
            “metadata”: [ “user_controlled”, “user_modifiable”, “extension_modifiable” ],
            “value”: “BRV001”
         },

ensured that there was a daily usage ping via laptop-updates.brave.com that included the BRV001 on first launch

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=true&woi=2023-10-30&dtoi=2023-11-01&ref=BRV001&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 day and ensured that daily=true & ref=BRV001

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=false&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV001&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 week and ensured that daily=true&weekly=true & ref=BRV001`

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV001&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 month and ensured that daily=true&weekly=true&monthly=true & ref=BRV001

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV001&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

Using Brave-Browser-BRV001-universal.dmg - PASSED

Verification PASSED on macOS 14.0 Sonoma x64 using the following build(s):

Brave | 1.60.110 Chromium: 119.0.6045.105 (Official Build) (x86_64)
--- | ---
Revision | 0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS | macOS Version 14.0 (Build 23A344)

Quick note: The above requires specific executables which can be downloaded via https://bravesoftware.slack.com/archives/C05FK45FN0M/p1698866128534639?thread_ts=1697728273.865229&cid=C05FK45FN0M.

downloaded Brave-Browser-BRV001-universal.dmg and ensured Brave installed without any issues/failures/crashes
launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV001”}; as per the following:

“promo_code”: {
            “metadata”: [ “user_controlled”, “user_modifiable”, “extension_modifiable” ],
            “value”: “BRV001”
         },

ensured that there was a daily usage ping via laptop-updates.brave.com that included the BRV001 on first launch

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=true&woi=2023-10-30&dtoi=2023-11-01&ref=BRV001&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 day and ensured that daily=true & ref=BRV001

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=false&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV001&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 week and ensured that daily=true&weekly=true & ref=BRV001`

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV001&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 month and ensured that daily=true&weekly=true&monthly=true & ref=BRV001

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV001&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

`BRV002 Referral Code`

Using Brave-Browser-BRV002-x64.dmg - PASSED

Verification PASSED on macOS 14.0 Sonoma x64 using the following build(s):

Brave | 1.60.110 Chromium: 119.0.6045.105 (Official Build) (x86_64)
--- | ---
Revision | 0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS | macOS Version 14.0 (Build 23A344)

Quick note: The above requires specific executables which can be downloaded via https://bravesoftware.slack.com/archives/C05FK45FN0M/p1698866128534639?thread_ts=1697728273.865229&cid=C05FK45FN0M.

downloaded Brave-Browser-BRV002-x64.dmg and ensured Brave installed without any issues/failures/crashes
launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV002”}; as per the following:

“promo_code”: {
            “metadata”: [ “user_controlled”, “user_modifiable”, “extension_modifiable” ],
            “value”: “BRV002”
         },

ensured that there was a daily usage ping via laptop-updates.brave.com that included the BRV002 on first launch

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=true&woi=2023-10-30&dtoi=2023-11-01&ref=BRV002&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 day and ensured that daily=true & ref=BRV002

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=false&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV002&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 week and ensured that daily=true&weekly=true & ref=BRV002`

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV002&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 month and ensured that daily=true&weekly=true&monthly=true & ref=BRV002

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV002&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

Using Brave-Browser-BRV002-universal.dmg - PASSED

Verification PASSED on macOS 14.0 Sonoma x64 using the following build(s):

Brave | 1.60.110 Chromium: 119.0.6045.105 (Official Build) (x86_64)
--- | ---
Revision | 0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS | macOS Version 14.0 (Build 23A344)

Quick note: The above requires specific executables which can be downloaded via https://bravesoftware.slack.com/archives/C05FK45FN0M/p1698866128534639?thread_ts=1697728273.865229&cid=C05FK45FN0M.

downloaded Brave-Browser-BRV002-universal.dmg and ensured Brave installed without any issues/failures/crashes
launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV002”}; as per the following:

“promo_code”: {
            “metadata”: [ “user_controlled”, “user_modifiable”, “extension_modifiable” ],
            “value”: “BRV002”
         },

ensured that there was a daily usage ping via laptop-updates.brave.com that included the BRV001 on first launch

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=true&woi=2023-10-30&dtoi=2023-11-01&ref=BRV002&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 day and ensured that daily=true & ref=BRV001

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=false&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV002&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 week and ensured that daily=true&weekly=true & ref=BRV001`

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV002&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 month and ensured that daily=true&weekly=true&monthly=true & ref=BRV001

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV002&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

`BRV010 Referral Code`

Using Brave-Browser-BRV010-x64.dmg - PASSED

Verification PASSED on macOS 14.0 Sonoma x64 using the following build(s):

Brave | 1.60.110 Chromium: 119.0.6045.105 (Official Build) (x86_64)
--- | ---
Revision | 0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS | macOS Version 14.0 (Build 23A344)

Quick note: The above requires specific executables which can be downloaded via https://bravesoftware.slack.com/archives/C05FK45FN0M/p1698866128534639?thread_ts=1697728273.865229&cid=C05FK45FN0M.

downloaded Brave-Browser-BRV010-x64.dmg and ensured Brave installed without any issues/failures/crashes
launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV010”}; as per the following:

“promo_code”: {
            “metadata”: [ “user_controlled”, “user_modifiable”, “extension_modifiable” ],
            “value”: “BRV010”
         },

ensured that there was a daily usage ping via laptop-updates.brave.com that included the BRV010 on first launch

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=true&woi=2023-10-30&dtoi=2023-11-01&ref=BRV010&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 day and ensured that daily=true & ref=BRV010

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=false&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV010&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 week and ensured that daily=true&weekly=true & ref=BRV010`

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV010&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 month and ensured that daily=true&weekly=true&monthly=true & ref=BRV010

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV010&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

Using Brave-Browser-BRV010-universal.dmg - PASSED

Verification PASSED on macOS 14.0 Sonoma x64 using the following build(s):

Brave | 1.60.110 Chromium: 119.0.6045.105 (Official Build) (x86_64)
--- | ---
Revision | 0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS | macOS Version 14.0 (Build 23A344)

Quick note: The above requires specific executables which can be downloaded via https://bravesoftware.slack.com/archives/C05FK45FN0M/p1698866128534639?thread_ts=1697728273.865229&cid=C05FK45FN0M.

downloaded Brave-Browser-BRV010-universal.dmg and ensured Brave installed without any issues/failures/crashes
launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV010”}; as per the following:

“promo_code”: {
            “metadata”: [ “user_controlled”, “user_modifiable”, “extension_modifiable” ],
            “value”: “BRV010”
         },

ensured that there was a daily usage ping via laptop-updates.brave.com that included the BRV010 on first launch

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=true&woi=2023-10-30&dtoi=2023-11-01&ref=BRV010&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 day and ensured that daily=true & ref=BRV010

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=false&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV010&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 week and ensured that daily=true&weekly=true & ref=BRV010`

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV010&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

closed Brave/moved the date ahead by 1 month and ensured that daily=true&weekly=true&monthly=true & ref=BRV010

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV010&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

`.pkg check using BRV002`

Using Brave-Browser-BRV010.pkg - PASSED

Verification PASSED on macOS 14.0 Sonoma x64 using the following build(s):

Brave | 1.60.110 Chromium: 119.0.6045.105 (Official Build) (x86_64)
--- | ---
Revision | 0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS | macOS Version 14.0 (Build 23A344)

downloaded Brave-Browser-universal.pkg from GH for 1.60.110
renamed file to be Brave-Browser-BRV010.pkg
Installed from this renamed pkg file and ensured Brave installed without any issues/failures/crashes

before launching, checked that promoCode file was created under the profile folder as below:

launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV010”}; as per the following:

“promo_code”: {
            “metadata”: [ “user_controlled”, “user_modifiable”, “extension_modifiable” ],
            “value”: “BRV010”
         },

ensured that there was a daily usage ping via laptop-updates.brave.com that included the BRV010 on first launch

GET /1/usage/brave-core?platform=osx-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=true&woi=2023-10-30&dtoi=2023-11-02&ref=BRV010&adsEnabled=false&arch=&wallet2=0 HTTP/1.1

LaurenWags · 2023-11-01T20:09:34Z

`macOS 14.x Sonoma arm64`

`BRV001 Referral Code`

Using Brave-Browser-BRV001-arm64.dmg - PASSED

Verification PASSED on macOS 14.x Sonoma arm64 using the following build(s):

Brave	1.60.110 Chromium: 119.0.6045.105 (Official Build) (arm64) 
Revision	0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS	macOS Version 14.1 (Build 23B5067a)

Quick note: The above requires specific executables which can be downloaded via https://bravesoftware.slack.com/archives/C05FK45FN0M/p1698866128534639?thread_ts=1697728273.865229&cid=C05FK45FN0M.

downloaded Brave-Browser-BRV001-arm64.dmg and ensured Brave installed without any issues/failures/crashes
launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV001”}; as per the following:

         "promo_code": {
            "metadata": [ "user_controlled", "user_modifiable", "extension_modifiable" ],
            "value": "BRV001"
         },

ensured that there was a daily usage ping via laptop-updates.brave.com that included the BRV001 on first launch

laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=true&woi=2023-10-30&dtoi=2023-11-01&ref=BRV001&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 day and ensured that daily=true & ref=BRV001

laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=false&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV001&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 week and ensured that daily=true&weekly=true & ref=BRV001

laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV001&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 month and ensured that daily=true&weekly=true&monthly=true & ref=BRV001

laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV001&adsEnabled=false&arch=&wallet2=0

`BRV002 Referral Code`

Using Brave-Browser-BRV002-universal.dmg - PASSED

Verification PASSED on macOS 14.x Sonoma arm64 using the following build(s):

Brave	1.60.110 Chromium: 119.0.6045.105 (Official Build) (arm64) 
Revision	0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS	macOS Version 14.1 (Build 23B5067a)

Quick note: The above requires specific executables which can be downloaded via https://bravesoftware.slack.com/archives/C05FK45FN0M/p1698866128534639?thread_ts=1697728273.865229&cid=C05FK45FN0M.

downloaded Brave-Browser-BRV002-universal.dmg and ensured Brave installed without any issues/failures/crashes
launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV002”}; as per the following:

         "promo_code": {
            "metadata": [ "user_controlled", "user_modifiable", "extension_modifiable" ],
            "value": "BRV002"
         },

ensured that there was a daily usage ping via laptop-updates.brave.com that included the BRV002 on first launch

laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=true&woi=2023-10-30&dtoi=2023-11-01&ref=BRV002&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 day and ensured that daily=true & ref=BRV002

laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=false&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV002&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 week and ensured that daily=true&weekly=true & ref=BRV002

laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV002&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 month and ensured that daily=true&weekly=true&monthly=true & ref=BRV002

laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV002&adsEnabled=false&arch=&wallet2=0

`BRV010 Referral Code`

Using Brave-Browser-BRV010-universal.dmg - PASSED

Verification PASSED on macOS 14.x Sonoma arm64 using the following build(s):

Brave	1.60.110 Chromium: 119.0.6045.105 (Official Build) (arm64) 
Revision	0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS	macOS Version 14.1 (Build 23B5067a)

Quick note: The above requires specific executables which can be downloaded via https://bravesoftware.slack.com/archives/C05FK45FN0M/p1698866128534639?thread_ts=1697728273.865229&cid=C05FK45FN0M.

downloaded Brave-Browser-BRV010-universal.dmg and ensured Brave installed without any issues/failures/crashes
launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV010”}; as per the following:

         "promo_code": {
            "metadata": [ "user_controlled", "user_modifiable", "extension_modifiable" ],
            "value": "BRV010"
         },

ensured that there was a daily usage ping via laptop-updates.brave.com that included the BRV010 on first launch

laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=true&woi=2023-10-30&dtoi=2023-11-01&ref=BRV010&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 day and ensured that daily=true & ref=BRV010

laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=false&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV010&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 week and ensured that daily=true&weekly=true & ref=BRV010

laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV010&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 month and ensured that daily=true&weekly=true&monthly=true & ref=BRV010

laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV010&adsEnabled=false&arch=&wallet2=0

`.pkg check using BRV002`

Using Brave-Browser-BRV002.pkg - PASSED

Verification PASSED on macOS 14.x Sonoma arm64 using the following build(s):

Brave	1.60.110 Chromium: 119.0.6045.105 (Official Build) (arm64) 
Revision	0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS	macOS Version 14.1 (Build 23B5067a)

downloaded Brave-Browser-universal.pkg from GH for 1.60.110
renamed file to be Brave-Browser-BRV002.pkg
Installed from this renamed pkg file and ensured Brave installed without any issues/failures/crashes

before launching, checked that promoCode file was created under the profile folder as below:

launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV002”}; as per the following:

         "promo_code": {
            "metadata": [ "user_controlled", "user_modifiable", "extension_modifiable" ],
            "value": "BRV002"
         },

`macOS 10.15.x Catalina x64`

`BRV002 Referral Code`

Using Brave-Browser-BRV002-universal.dmg - PASSED

Verification PASSED on macOS 10.15.x Catalina x64 using the following build(s):

Brave	1.60.110 Chromium: 119.0.6045.105 (Official Build) (x86_64) 
Revision	0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS	macOS Version 10.15.7 (Build 19H1824)

Quick note: The above requires specific executables which can be downloaded via https://bravesoftware.slack.com/archives/C05FK45FN0M/p1698866128534639?thread_ts=1697728273.865229&cid=C05FK45FN0M.

downloaded Brave-Browser-BRV002-universal.dmg and ensured Brave installed without any issues/failures/crashes
launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV002”}; as per the following:

         "promo_code": {
            "metadata": [ "user_controlled", "user_modifiable", "extension_modifiable" ],
            "value": "BRV002"
         },

`.pkg check using BRV002`

Using Brave-Browser-BRV002.pkg - PASSED

Verification PASSED on macOS 10.15.x Catalina x64 using the following build(s):

Brave	1.60.110 Chromium: 119.0.6045.105 (Official Build) (x86_64) 
Revision	0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS	macOS Version 10.15.7 (Build 19H1824)

downloaded Brave-Browser-universal.pkg from GH for 1.60.110
renamed file to be Brave-Browser-BRV002.pkg
Installed from this renamed pkg file and ensured Brave installed without any issues/failures/crashes

before launching, checked that promoCode file was created under the profile folder as below:

launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV002”}; as per the following:

         "promo_code": {
            "metadata": [ "user_controlled", "user_modifiable", "extension_modifiable" ],
            "value": "BRV002"
         },

stephendonner · 2023-11-01T20:36:35Z

`macOS 13.6.1 Ventura arm64`

`BRV001 Referral Code` - `PASSED`

Using Brave-Browser-BRV001-arm64.dmg - PASSED

Verification PASSED on macOS 14.0 Sonoma x64 using the following build(s):

Brave | 1.60.110 Chromium: 119.0.6045.105 (Official Build) (arm64)
-- | --
Revision | 0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS | macOS Version 13.6.1 (Build 22G313)

Quick note: The above requires specific executables which can be downloaded via https://bravesoftware.slack.com/archives/C05FK45FN0M/p1698866128534639?thread_ts=1697728273.865229&cid=C05FK45FN0M.

downloaded Brave-Browser-BRV001-x64.dmg and ensured Brave installed without any issues/failures/crashes
launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV001”}; as per the following:

“promo_code”: {
            “metadata”: [ “user_controlled”, “user_modifiable”, “extension_modifiable” ],
            “value”: “BRV001”
         },

ensured that there was a daily usage ping via laptop-updates.brave.com that included the BRV001 on first launch

GET https://laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=true&woi=2023-10-30&dtoi=2023-11-01&ref=BRV001&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 day and ensured that daily=true & ref=BRV001

GET https://laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=false&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV001&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 week and ensured that daily=true&weekly=true & ref=BRV001`

GET https://laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV001&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 month and ensured that daily=true&weekly=true&monthly=true & ref=BRV001

GET [/1/usage/brave-core?platform=osx-bc&channel=release&version=1.59.124&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV001&adsEnabled=false&arch=&wallet2=0 HTTP/1.1](https://laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV001&adsEnabled=false&arch=&wallet2=0)

`BRV002 Referral Code` - `PASSED`

Using Brave-Browser-BRV002-universal.dmg - PASSED

downloaded Brave-Browser-BRV002-universal.dmg and ensured Brave installed without any issues/failures/crashes
launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV002”}; as per the following:

“promo_code”: {
            “metadata”: [ “user_controlled”, “user_modifiable”, “extension_modifiable” ],
            “value”: “BRV002”
         },

ensured that there was a daily usage ping via laptop-updates.brave.com that included the BRV002 on first launch

GET https://laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV002&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 day and ensured that daily=true & ref=BRV002

GET https://laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=false&monthly=false&first=false&woi=2023-10-30&dtoi=null&ref=BRV002&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 week and ensured that daily=true&weekly=true & ref=BRV002

GET https://laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV002&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 month and ensured that daily=true&weekly=true&monthly=true & ref=BRV002

GET https://laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV002&adsEnabled=false&arch=&wallet2=0

`BRV010 Referral Code` - `PASSED`

Using Brave-Browser-BRV010-universal.dmg - PASSED

downloaded Brave-Browser-BRV010-universal.dmg and ensured Brave installed without any issues/failures/crashes
launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV010”}; as per the following:

“promo_code”: {
            “metadata”: [ “user_controlled”, “user_modifiable”, “extension_modifiable” ],
            “value”: “BRV010”
         },

ensured that there was a daily usage ping via laptop-updates.brave.com that included the BRV010 on first launch

GET https://laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=true&woi=2023-10-30&dtoi=2023-11-01&ref=BRV010&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 day and ensured that daily=true & ref=BRV010

GET https://laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=false&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV010&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 week and ensured that daily=true&weekly=true & ref=BRV010

GET https://laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=false&first=false&woi=2023-10-30&dtoi=2023-11-01&ref=BRV010&adsEnabled=false&arch=&wallet2=0

closed Brave/moved the date ahead by 1 month and ensured that daily=true&weekly=true&monthly=true & ref=BRV010

GET https://laptop-updates.brave.com/1/usage/brave-core?platform=osxarm64-bc&channel=release&version=1.60.110&daily=true&weekly=true&monthly=true&first=false&woi=2023-10-30&dtoi=null&ref=BRV010&adsEnabled=false&arch=&wallet2=0

`.pkg check using BRV002` - `PASSED`

Using Brave-Browser-BRV002.pkg - PASSED

Verification PASSED on macOS 13.6.1 Ventura arm64 using the following build(s):

Brave	1.60.110 Chromium: 119.0.6045.105 (Official Build) (arm64) 
Revision	0bb6e7a81aed340b5a9e8b752c1cf92768257c40
OS	macOS Version 14.1 (Build 23B5067a)

downloaded Brave-Browser-universal.pkg from GH for 1.60.110
renamed file to be Brave-Browser-QPU818.pkg
Installed from this renamed pkg file and ensured Brave installed without any issues/failures/crashes

before launching, checked that promoCode file was created under the profile folder as below:

launched Brave and ensured there were no obvious issues (performance/crashes)
checked brave://local-state and ensured that “promo_code”: { “value”: “BRV002”}; as per the following:

         "promo_code": {
            "metadata": [ "user_controlled", "user_modifiable", "extension_modifiable" ],
            "value": "BRV002"
         },

The `.pkg` binary was replaced by a regular `.dmg` in 1.60: brave/brave-browser#32316

pes10k added the OS/Desktop label Aug 16, 2023

rebron added OS/macOS setup/installer priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes labels Aug 16, 2023

bsclifton assigned mkarolin Sep 22, 2023

mkarolin added the release-notes/exclude label Sep 22, 2023

mkarolin mentioned this issue Sep 22, 2023

Get refcode on MacOS from xattr. brave/brave-core#20262

Merged

25 tasks

mkarolin closed this as completed in brave/brave-core#20262 Sep 29, 2023

mkarolin added this to the 1.60.x - Nightly milestone Sep 29, 2023

brave-builds mentioned this issue Oct 2, 2023

Get refcode on MacOS from xattr. (uplift to 1.59.x) brave/brave-core#20352

Closed

7 tasks

bsclifton mentioned this issue Oct 4, 2023

Referral build Windows installer could use tagging instead of special filenames #1511

Open

LaurenWags added OS/macOS-arm64 QA/Blocked labels Oct 6, 2023

kjozwiak removed the QA/Blocked label Nov 1, 2023

kjozwiak added the QA Pass-macOS label Nov 2, 2023

LaurenWags added the QA Pass-macOS-arm64 label Nov 2, 2023

kjozwiak mentioned this issue Feb 27, 2024

Changing pkg -> dmg on brave.com brave/qa-resources#582

Closed

fmarier added a commit to fmarier/privacyguides.org that referenced this issue Jul 17, 2024

Remove obsolete warning about PKG on macOS

3e89108

The `.pkg` binary was replaced by a regular `.dmg` in 1.60: brave/brave-browser#32316

fmarier mentioned this issue Jul 17, 2024

Update obsolete Brave info (pkg on macOS) privacyguides/privacyguides.org#2647

Merged

1 task

fmarier added a commit to fmarier/privacyguides.org that referenced this issue Jul 17, 2024

docs: Remove obsolete warning about PKG on macOS

5352124

The `.pkg` binary was replaced by a regular `.dmg` in 1.60: brave/brave-browser#32316

fmarier added a commit to fmarier/privacyguides.org that referenced this issue Jul 17, 2024

update: Remove obsolete warning about PKG on macOS

7ffa65d

The `.pkg` binary was replaced by a regular `.dmg` in 1.60: brave/brave-browser#32316

fmarier added a commit to fmarier/privacyguides.org that referenced this issue Jul 19, 2024

update: Remove obsolete warning about PKG on macOS

b8afa3c

The `.pkg` binary was replaced by a regular `.dmg` in 1.60: brave/brave-browser#32316

fmarier added a commit to fmarier/privacyguides.org that referenced this issue Jul 20, 2024

update: Remove obsolete warning about PKG on macOS

67cdae5

The `.pkg` binary was replaced by a regular `.dmg` in 1.60: brave/brave-browser#32316

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Brave MacOS downloads should not use .pkg #32316

Brave MacOS downloads should not use .pkg #32316

pes10k commented Aug 16, 2023

rebron commented Sep 1, 2023

bsclifton commented Sep 15, 2023

bridiver commented Sep 21, 2023

LaurenWags commented Oct 6, 2023

kjozwiak commented Nov 1, 2023 •

edited

Loading

LaurenWags commented Nov 1, 2023 •

edited

Loading

stephendonner commented Nov 1, 2023 •

edited

Loading

Brave MacOS downloads should not use .pkg #32316

Brave MacOS downloads should not use .pkg #32316

Comments

pes10k commented Aug 16, 2023

rebron commented Sep 1, 2023

bsclifton commented Sep 15, 2023

bridiver commented Sep 21, 2023

LaurenWags commented Oct 6, 2023

kjozwiak commented Nov 1, 2023 • edited Loading

macOS 14.0 Sonoma x64

BRV001 Referral Code

BRV002 Referral Code

BRV010 Referral Code

.pkg check using BRV002

LaurenWags commented Nov 1, 2023 • edited Loading

macOS 14.x Sonoma arm64

BRV001 Referral Code

BRV002 Referral Code

BRV010 Referral Code

.pkg check using BRV002

macOS 10.15.x Catalina x64

BRV002 Referral Code

.pkg check using BRV002

stephendonner commented Nov 1, 2023 • edited Loading

macOS 13.6.1 Ventura arm64

BRV001 Referral Code - PASSED

BRV002 Referral Code - PASSED

BRV010 Referral Code - PASSED

.pkg check using BRV002 - PASSED

kjozwiak commented Nov 1, 2023 •

edited

Loading

`macOS 14.0 Sonoma x64`

`BRV001 Referral Code`

`BRV002 Referral Code`

`BRV010 Referral Code`

`.pkg check using BRV002`

LaurenWags commented Nov 1, 2023 •

edited

Loading

`macOS 14.x Sonoma arm64`

`BRV001 Referral Code`

`BRV002 Referral Code`

`BRV010 Referral Code`

`.pkg check using BRV002`

`macOS 10.15.x Catalina x64`

`BRV002 Referral Code`

`.pkg check using BRV002`

stephendonner commented Nov 1, 2023 •

edited

Loading

`macOS 13.6.1 Ventura arm64`

`BRV001 Referral Code` - `PASSED`

`BRV002 Referral Code` - `PASSED`

`BRV010 Referral Code` - `PASSED`

`.pkg check using BRV002` - `PASSED`