fix(PrismicLink): do not warn about missing field properties if the Link field is empty #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This PR fixes a bug in
<PrismicLink>
where it logged a console warning about missing Link field properties when given an empty Link field value. Empty link values are valid and should not trigger the warning.The issue was unknown because the test to check this exact case was written incorrectly (see the fix).
Fixes #161
Thanks to @ReeceM for uncovering the issue!
Checklist:
🐈