fix(PrismicLink): do not warn about missing field properties if the L…

…ink field is empty (#163)
prismicio · Jul 30, 2022 · b138472 · b138472
1 parent 5be1649
commit b138472
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/PrismicLink.tsx b/src/PrismicLink.tsx
@@ -149,10 +149,8 @@ const _PrismicLink = <
 					)}`,
 				);
 			} else if (
-				!(
-					prismicH.isFilled.link(props.field) &&
-					("url" in props.field || "id" in props.field)
-				)
+				Object.keys(props.field).length > 1 &&
+				!("url" in props.field || "uid" in props.field || "id" in props.field)
 			) {
 				console.warn(
 					`[PrismicLink] The provided field is missing required properties to properly render a link. The link may not render correctly. For more details, see ${devMsg(

diff --git a/test/PrismicLink.test.tsx b/test/PrismicLink.test.tsx
@@ -457,7 +457,7 @@ test.serial(
 );
 
 test.serial("warns if properties are missing from a given field", (t) => {
-	const field = { link_type: prismicT.LinkType.Web };
+	const field = { link_type: prismicT.LinkType.Web, target: "_blank" };
 
 	const consoleWarnStub = sinon.stub(console, "warn");
 
@@ -480,7 +480,7 @@ test.serial("does not warn if given field is empty", (t) => {
 
 	consoleWarnStub.restore();
 
-	t.true(consoleWarnStub.calledWithMatch("missing-link-properties"));
+	t.false(consoleWarnStub.called);
 });
 
 test.serial("warns if properties are missing from a given document", (t) => {