Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: schema engine postgres WASM implementation #5136

Merged
merged 8 commits into from
Jan 30, 2025
Merged

feat: schema engine postgres WASM implementation #5136

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6618eea
feat: schema engine postgres WASM implementation
jacek-prisma Jan 24, 2025
a54f0e3
fix: add an impl to satsify tests
jacek-prisma Jan 24, 2025
734db63
fix: sqlite test issues
jacek-prisma Jan 24, 2025
2aa0c16
fix: fix tests and cleanup
jacek-prisma Jan 24, 2025
0425119
fix: avoid double connecting in open/drop db
jacek-prisma Jan 24, 2025
356df3d
Merge remote-tracking branch 'origin/main' into feat/schema-engine-po…
jacek-prisma Jan 24, 2025
07f35bb
chore: unnecessary Box::pin
jacek-prisma Jan 24, 2025
c306ec9
Merge remote-tracking branch 'origin/main' into feat/schema-engine-po…
jacek-prisma Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: unnecessary Box::pin
  • Loading branch information
@jacek-prisma
jacek-prisma committed Jan 24, 2025
commit 07f35bb39c79c9c82101a205346c3b58dc8e881d
2 changes: 1 addition & 1 deletion schema-engine/connectors/sql-schema-connector/src/flavour/postgres.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ impl SqlFlavour for PostgresFlavour {
}

fn drop_migrations_table(&mut self) -> BoxFuture<'_, ConnectorResult<()>> {
Box::pin(self.raw_cmd("DROP TABLE _prisma_migrations"))
self.raw_cmd("DROP TABLE _prisma_migrations")
Comment on lines -411 to +371
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in a call, we were previously applying Box::pin twice by accident, so this change is fine.

}

fn empty_database_schema(&self) -> SqlSchema {
Expand Down
Loading