-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: schema engine postgres WASM implementation #5136
Conversation
WASM Query Engine file Size
|
CodSpeed Performance ReportMerging #5136 will not alter performanceComparing Summary
|
Box::pin(self.raw_cmd("DROP TABLE _prisma_migrations")) | ||
self.raw_cmd("DROP TABLE _prisma_migrations") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in a call, we were previously applying Box::pin
twice by accident, so this change is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! The git diff
in this case is more drastic than it should be, most of the files that appear deleted are actually moved to another file
Closes ORM-506. Implements most of the schema engine API for Postgres for WASM.
Notes:
apply_migration_script
,create_database
,drop_database
, shadow databaseSqlSchemaDescriber
to make it compile against external connector