Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aria label consistency #498

Merged
merged 7 commits into from
Jul 19, 2019
Merged

Aria label consistency #498

merged 7 commits into from
Jul 19, 2019

Conversation

emplums
Copy link

@emplums emplums commented Jul 18, 2019

This PR makes the aria-label API consistent across all components! As pointed out in #494, some components were using props named text or label to set the aria-label. All components now just use aria-label. I've kept the previous prop functionality around for backwards compatibility.

Closes #494

@colebemis colebemis mentioned this pull request Jul 18, 2019
Merged
8 tasks
mxstbr
mxstbr reviewed Jul 19, 2019
View reviewed changes
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review here doesn't count for anything but this looks awesome! 💯 You might want to update the TypeScript typings too?

@emplums
Copy link
Author

emplums commented Jul 19, 2019

Oh yes, thanks for the heads up!

@emplums emplums changed the base branch from master to release-13.2.0 July 19, 2019 20:16
@emplums emplums merged commit 894f485 into release-13.2.0 Jul 19, 2019
@emplums emplums deleted the aria-label branch July 19, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxstbr mxstbr mxstbr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emplums @mxstbr