Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aria prop inconsistencies #494

Closed
mxstbr opened this issue Jul 3, 2019 · 1 comment
Closed

Aria prop inconsistencies #494

mxstbr opened this issue Jul 3, 2019 · 1 comment

Comments

@mxstbr
Copy link
Contributor

mxstbr commented Jul 3, 2019

While writing the TypeScript definitions for all the components (#490), I noticed inconsistencies in the names of aria props.

These all set the aria-label attribute on the rendered element:

  • TextInput.aria-label
  • Tooltip.text
  • UnderlineNav.label

It would be good if these were internally consistent with one another. I think the prop should be called aria-label across the board, as that's the clearest.

We could also make that change in a backwards-compatible manner, so that no existing apps built with these components are broken.

What do you think?

@emplums
Copy link

emplums commented Jul 18, 2019

This sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants