You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While writing the TypeScript definitions for all the components (#490), I noticed inconsistencies in the names of aria props.
These all set the aria-label attribute on the rendered element:
TextInput.aria-label
Tooltip.text
UnderlineNav.label
It would be good if these were internally consistent with one another. I think the prop should be called aria-label across the board, as that's the clearest.
We could also make that change in a backwards-compatible manner, so that no existing apps built with these components are broken.
What do you think?
The text was updated successfully, but these errors were encountered:
While writing the TypeScript definitions for all the components (#490), I noticed inconsistencies in the names of aria props.
These all set the
aria-label
attribute on the rendered element:TextInput.aria-label
Tooltip.text
UnderlineNav.label
It would be good if these were internally consistent with one another. I think the prop should be called
aria-label
across the board, as that's the clearest.We could also make that change in a backwards-compatible manner, so that no existing apps built with these components are broken.
What do you think?
The text was updated successfully, but these errors were encountered: