Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add package version numbers #4796

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jul 30, 2024

It seems like there is a bug in changesets that will fail in prerelease mode if there is no version available for a private workspace. This PR adds explicit version numbers to each workspace to prevent this from occurring.

Changelog

New

Changed

  • Add explicit version numbers to internal workspaces

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This is a change to internal private packages

@joshblack joshblack requested a review from a team as a code owner July 30, 2024 16:34
@joshblack joshblack requested a review from broccolinisoup July 30, 2024 16:34
Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: 6630ac8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Jul 30, 2024
@github-actions github-actions bot added the staff Author is a staff member label Jul 30, 2024
@joshblack joshblack requested a review from langermank July 30, 2024 16:36
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 95.76 KB (0%)
packages/react/dist/browser.umd.js 96.06 KB (0%)

Copy link
Contributor

@mperrotti mperrotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually know what these changes do, but it looks like it's just a test so I'm approving.

@joshblack joshblack added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit 01b396a Jul 30, 2024
37 of 38 checks passed
@joshblack joshblack deleted the chore/add-explicit-version-numbers branch July 30, 2024 17:54
TylerJDev pushed a commit that referenced this pull request Jul 31, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 9, 2024
* Focus close button on second step

* Remove `autofocus` prop

* Add dependencies to focus trap

* Add changeset

* lint fix

* Remove `body` from dependency

* add state to Dialog example

* chore(changeset): enter prerelease mode for v37 (#4789)

* chore(changeset): enter pre-release mode for v37

* ci: remove snapshots when in pre mode

* chore: add version info to all packages

* Revert "chore: add version info to all packages"

This reverts commit 4665bb3.

* chore: update canary to remove pre.json when running

---------

Co-authored-by: Josh Black <[email protected]>

* Autocomplete: Only open menu on click (#4771)

* Only open menu on click instead of just focus

* Update tests

* Add changeset

* Fix typo

* Set `openOnFocus` to `true`

* Add test, move `onFocus` function

* Update docs

* Adjust changeset

* Remove `useCallback`

* Add deprecated notice

* Prep for high contrast theme border-color changes (#4774)

* borders

* fallback

* test(vrt): update snapshots

* test color changes

* alright

* bump

* test(vrt): update snapshots

* more fixes

* test(vrt): update snapshots

* copy from main

* test(vrt): update snapshots

* Create fluffy-ravens-thank.md

* snippy snaps

* update seg control border

* test(vrt): update snapshots

* remove fallbacks

* copy from main

* test(vrt): update snapshots

---------

Co-authored-by: langermank <[email protected]>

* chore: add package version numbers (#4796)

Co-authored-by: Josh Black <[email protected]>

* feat: add postcss-preset-primer (#4751)

* feat: add postcss-preset-primer

* docs: update usage snippet

* chore: fix eslint rules and remove postcss-mixins

---------

Co-authored-by: Josh Black <[email protected]>

* Utilize `aria-describedby` on all `ActionList` descriptions (#4666)

* Add `aria-describedby` to inline description; add `aria-labelledby` to `TrailingVisual`

* Update snapshots

* Add changeset

* Update snapshot

* Update packages/react/src/ActionList/Item.tsx

Co-authored-by: Siddharth Kshetrapal <[email protected]>

* changes from PR feedback

* Update .changeset/lovely-days-march.md

* Update snapshots

* Update lovely-days-march.md

---------

Co-authored-by: Siddharth Kshetrapal <[email protected]>

* Wrap `header` and `footer` with `<Box>`

* Move `<Box>`

* Add back focus to story

* Update behaviors package

* Move back `useFocusTrap`

---------

Co-authored-by: Siddharth Kshetrapal <[email protected]>
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Katie Langerman <[email protected]>
Co-authored-by: langermank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants