feat: add postcss-preset-primer #4751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jonrohan
reviewed
Jul 18, 2024
size-limit report 📦
|
langermank
approved these changes
Jul 30, 2024
TylerJDev
pushed a commit
that referenced
this pull request
Jul 31, 2024
* feat: add postcss-preset-primer * docs: update usage snippet * chore: fix eslint rules and remove postcss-mixins --------- Co-authored-by: Josh Black <[email protected]>
|
Any hint maybe on when could this be available for install? Just wanted to give it a spin according to the getting started ¯\(ツ)/¯ but got this: rocskaadam@Rocska-MBP src.adam-rocska.github.io % pnpm install postcss-preset-primer --save-dev
ERR_PNPM_FETCH_404 GET https://registry.npmjs.org/postcss-preset-primer: Not Found - 404
This error happened while installing a direct dependency of /Users/rocskaadam/src/adam-rocska/src/src.adam-rocska.github.io
postcss-preset-primer is not in the npm registry, or you have no permission to fetch it.
No authorization header was set for the request.
Progress: resolved 16, reused 16, downloaded 0, added 0 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Focus close button on second step * Remove `autofocus` prop * Add dependencies to focus trap * Add changeset * lint fix * Remove `body` from dependency * add state to Dialog example * chore(changeset): enter prerelease mode for v37 (#4789) * chore(changeset): enter pre-release mode for v37 * ci: remove snapshots when in pre mode * chore: add version info to all packages * Revert "chore: add version info to all packages" This reverts commit 4665bb3. * chore: update canary to remove pre.json when running --------- Co-authored-by: Josh Black <[email protected]> * Autocomplete: Only open menu on click (#4771) * Only open menu on click instead of just focus * Update tests * Add changeset * Fix typo * Set `openOnFocus` to `true` * Add test, move `onFocus` function * Update docs * Adjust changeset * Remove `useCallback` * Add deprecated notice * Prep for high contrast theme border-color changes (#4774) * borders * fallback * test(vrt): update snapshots * test color changes * alright * bump * test(vrt): update snapshots * more fixes * test(vrt): update snapshots * copy from main * test(vrt): update snapshots * Create fluffy-ravens-thank.md * snippy snaps * update seg control border * test(vrt): update snapshots * remove fallbacks * copy from main * test(vrt): update snapshots --------- Co-authored-by: langermank <[email protected]> * chore: add package version numbers (#4796) Co-authored-by: Josh Black <[email protected]> * feat: add postcss-preset-primer (#4751) * feat: add postcss-preset-primer * docs: update usage snippet * chore: fix eslint rules and remove postcss-mixins --------- Co-authored-by: Josh Black <[email protected]> * Utilize `aria-describedby` on all `ActionList` descriptions (#4666) * Add `aria-describedby` to inline description; add `aria-labelledby` to `TrailingVisual` * Update snapshots * Add changeset * Update snapshot * Update packages/react/src/ActionList/Item.tsx Co-authored-by: Siddharth Kshetrapal <[email protected]> * changes from PR feedback * Update .changeset/lovely-days-march.md * Update snapshots * Update lovely-days-march.md --------- Co-authored-by: Siddharth Kshetrapal <[email protected]> * Wrap `header` and `footer` with `<Box>` * Move `<Box>` * Add back focus to story * Update behaviors package * Move back `useFocusTrap` --------- Co-authored-by: Siddharth Kshetrapal <[email protected]> Co-authored-by: Josh Black <[email protected]> Co-authored-by: Josh Black <[email protected]> Co-authored-by: Katie Langerman <[email protected]> Co-authored-by: langermank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As more and more places are using/compiling CSS with Primer, it would be helpful to have a package for this that acts as a preset for the various plugins/strategies that we recommend.
This PR adds in a proof-of-concept package for this,
postcss-preset-primer, that can be shared and reused for compiling CSS for Primer.Changelog
New
postcss-preset-primerpackageChanged
Removed
Rollout strategy
This package is currently private