Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch scroll direction for beat snap #31277

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

kongehund
Copy link
Contributor

Matches stable

@bdach
Copy link
Collaborator

bdach commented Dec 26, 2024

I was worried this was going to happen but did not double check the bindings against stable to make sure.......... unless this was explicitly intended? @peppy please advise

If this PR is to go in the note in #31147 (comment) still applies. As in this won't actually change any bindings for users. (Why do I have to keep pointing this out? Surely you would find this out if you tested this?) The easiest solution to that would be to bump realm schema version again, and bump the version number on that specific switch block added in 9ff4a58 to rerun the migration.

@peppy
Copy link
Member

peppy commented Dec 26, 2024

Hmm, not sure about this one. I didn't change the directionality in lazer in my PR (very intentionally, albeit without checking against stable), and still feel like what we have is more natural.

Will have a play and see how weird this feels.

@peppy
Copy link
Member

peppy commented Dec 26, 2024

I don't know, up/down on mouse wheel seems to be arbitrary at best when the resulting action isn't a vertical adjustment (such as this case).

I'd say we probably just match stable here and call it a day for now. Users can adjust as they see fit 🤷

@peppy peppy self-requested a review December 26, 2024 06:40
@peppy peppy requested a review from bdach December 26, 2024 06:50
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh

@bdach bdach merged commit fa0d2f4 into ppy:master Dec 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants