Fix player settings overlay cog overlapping skin elements

[peppy]

This brings it down to be in line with the flowing elements that usually do their best to not get in the way.

Decided against putting it in the HUDOverlay flow for simplicity. It will work fine until it doesn't.

osu.2024-12-13.at.08.29.32.mp4

• Depends on Fix player settings overlay appearing while in skin editor #31105 for ease of merging

[smoogipoo]

I don't know why this is doing its own thing and not just a skinnable element. I struggle to imagine this is going to last given that there are now three places doing very similar things, the others being all this silliness:

osu/osu.Game/Skinning/LegacySkin.cs

Lines 383 to 410 in c29c3d4

	return new DefaultSkinComponentsContainer(container =>
	{
	var score = container.OfType<LegacyScoreCounter>().FirstOrDefault();
	var accuracy = container.OfType<GameplayAccuracyCounter>().FirstOrDefault();
	if (score != null && accuracy != null)
	{
	accuracy.Y = container.ToLocalSpace(score.ScreenSpaceDrawQuad.BottomRight).Y;
	}
	var songProgress = container.OfType<LegacySongProgress>().FirstOrDefault();
	if (songProgress != null && accuracy != null)
	{
	songProgress.Anchor = Anchor.TopRight;
	songProgress.Origin = Anchor.CentreRight;
	songProgress.X = -accuracy.ScreenSpaceDeltaToParentSpace(accuracy.ScreenSpaceDrawQuad.Size).X - 18;
	songProgress.Y = container.ToLocalSpace(accuracy.ScreenSpaceDrawQuad.TopLeft).Y + (accuracy.ScreenSpaceDeltaToParentSpace(accuracy.ScreenSpaceDrawQuad.Size).Y / 2);
	}
	var hitError = container.OfType<HitErrorMeter>().FirstOrDefault();
	if (hitError != null)
	{
	hitError.Anchor = Anchor.BottomCentre;
	hitError.Origin = Anchor.CentreLeft;
	hitError.Rotation = -90;
	}

osu/osu.Game/Screens/Play/HUDOverlay.cs

Lines 257 to 290 in e2af882

	if (drawableRuleset != null)
	{
	Quad playfieldScreenSpaceDrawQuad = drawableRuleset.Playfield.SkinnableComponentScreenSpaceDrawQuad;
	PlayfieldSkinLayer.Position = ToLocalSpace(playfieldScreenSpaceDrawQuad.TopLeft);
	PlayfieldSkinLayer.Width = (ToLocalSpace(playfieldScreenSpaceDrawQuad.TopRight) - ToLocalSpace(playfieldScreenSpaceDrawQuad.TopLeft)).Length;
	PlayfieldSkinLayer.Height = (ToLocalSpace(playfieldScreenSpaceDrawQuad.BottomLeft) - ToLocalSpace(playfieldScreenSpaceDrawQuad.TopLeft)).Length;
	PlayfieldSkinLayer.Rotation = drawableRuleset.PlayfieldAdjustmentContainer.Rotation;
	}
	float? lowestTopScreenSpaceLeft = null;
	float? lowestTopScreenSpaceRight = null;
	Vector2? highestBottomScreenSpace = null;
	processDrawables(mainComponents);
	if (rulesetComponents != null)
	processDrawables(rulesetComponents);
	if (lowestTopScreenSpaceRight.HasValue)
	topRightElements.Y = MathHelper.Clamp(ToLocalSpace(new Vector2(0, lowestTopScreenSpaceRight.Value)).Y, 0, DrawHeight - topRightElements.DrawHeight);
	else
	topRightElements.Y = 0;
	if (lowestTopScreenSpaceLeft.HasValue)
	LeaderboardFlow.Y = MathHelper.Clamp(ToLocalSpace(new Vector2(0, lowestTopScreenSpaceLeft.Value)).Y, 0, DrawHeight - LeaderboardFlow.DrawHeight);
	else
	LeaderboardFlow.Y = 0;
	if (highestBottomScreenSpace.HasValue)
	bottomRightElements.Y = BottomScoringElementsHeight = -MathHelper.Clamp(DrawHeight - ToLocalSpace(highestBottomScreenSpace.Value).Y, 0, DrawHeight - bottomRightElements.DrawHeight);
	else
	bottomRightElements.Y = 0;