Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix player settings overlay appearing while in skin editor #31105

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix player settings overlay appearing while in skin editor #31105

merged 2 commits into from
Dec 13, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented Dec 13, 2024

Closes #31088.

Also stops the settings appearing if the mouse is too far away from the window.

@peppy peppy mentioned this pull request Dec 13, 2024
Merged
1 task
smoogipoo
smoogipoo approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the overlay appearing when you hover close to the game from the right side, I would expect a left-to-right movement to be required. But this is probably okay for now.

@smoogipoo smoogipoo merged commit c29c3d4 into ppy:master Dec 13, 2024
10 checks passed
@Joehuu Joehuu mentioned this pull request Dec 15, 2024
Closed
@peppy peppy deleted the player-settings-no-show-skin-editor branch December 22, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees
No one assigned
Labels
area:skin-editor size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not show view settings in the skin editor
2 participants
@peppy @smoogipoo