Fix various catch distance snap grid breakage #25240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regressed in ppy#25171. The old code was kinda dependent on correct order of setting `Disabled`. `CatchHitObjectComposer` would disable distance spacing in its BDL, and then via the base `DistancedHitObjectComposer.LoadComplete()`, the slider would be faded out. The switch to composition broke that ordering. To fix, stop relying on ordering and just respond to changes as they come. That's what bindables are for.
bdach
changed the title
frenzibyte
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25238.
359ae31: Fix catch distance snap grid not moving
Regressed in #25154. Specifically, in 013b5fa and 74b8634.
A simple case of too-much-code-deleted-itis.
79910df: Fix catch distance snap provider not hiding slider properly
Regressed in #25171.
The old code was kinda dependent on correct order of setting
Disabled.CatchHitObjectComposerwould disable distance spacing in its BDL, and then via the baseDistancedHitObjectComposer.LoadComplete(), the slider would be faded out. The switch to composition broke that ordering.To fix, stop relying on ordering and just respond to changes as they come. That's what bindables are for.
I am not adding test coverage for these unless absolutely forced because these are dumb refactor errors and they will 99% not happen again.